Re: Getting data from template?
Mathew Robertson <[email protected]> Fri, 30 Jan 2009 14:46:09 +1100
| Newsgroups | gmane.comp.lang.perl.modules.html-template |
|---|---|
| Organization | Nielsen//NetRatings |
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============8683999799290430913== Content-Type: multipart/alternative; boundary="------------070501050508000503000405" This is a multi-part message in MIME format. --------------070501050508000503000405 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit >> I did some performance profiling of H::T some time ago -> it turns out >> that there is quite a bit of speed up (somewhere between 10% and 10x, >> depending on the page) by re-writing part of the code located around >> line 2660. >> > > Does this pass all the .t tests? If it does then shouldn't this get > accepted into H::T as a patch? Care to supply the change as a diff? > > Sorry for the shameless blog plug, but I only learnt how to use diff and > patch recently and blogged about how to to do:- > http://perl.bristolbath.org/blog/lyle/2009/01/how-to-submit-perl-patches.html#more > Not sure if it passes every test -> I use a heavily modified version of H::T which supports dynamic loading of escape-modules, support for arbitrary TMPL_xxx syntax, an odd bug fix + some other goodies... so I haven't specifically tested it against 2.10. That same reason also makes it hard to generate an isolated patch. I have posted this code before, but AFAICR there wasn't much discussion of merging it. cheers, Mathew --------------070501050508000503000405 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> <br> <blockquote cite="mid:[email protected]" type="cite"> <blockquote type="cite"> <pre wrap="">I did some performance profiling of H::T some time ago -> it turns out that there is quite a bit of speed up (somewhere between 10% and 10x, depending on the page) by re-writing part of the code located around line 2660. </pre> </blockquote> <pre wrap=""><!----> Does this pass all the .t tests? If it does then shouldn't this get accepted into H::T as a patch? Care to supply the change as a diff? Sorry for the shameless blog plug, but I only learnt how to use diff and patch recently and blogged about how to to do:- <a class="moz-txt-link-freetext" href="http://perl.bristolbath.org/blog/lyle/2009/01/how-to-submit-perl-patches.html#more">http://perl.bristolbath.org/blog/lyle/2009/01/how-to-submit-perl-patches.html#more</a> </pre> </blockquote> Not sure if it passes every test -> I use a heavily modified version of H::T which supports dynamic loading of escape-modules, support for arbitrary TMPL_xxx syntax, an odd bug fix + some other goodies... so I haven't specifically tested it against 2.10. That same reason also makes it hard to generate an isolated patch.<br> <br> I have posted this code before, but AFAICR there wasn't much discussion of merging it.<br> <br> cheers,<br> Mathew<br> </body> </html> --------------070501050508000503000405-- --===============8683999799290430913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword --===============8683999799290430913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Html-template-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/html-template-users --===============8683999799290430913==--