Re: Is development dead?
Chris Ridd <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.ldap |
|---|---|
| Message-ID | <[email protected]> |
On 19 Sep 2009, at 14:24, Graham Barr wrote: > On Sep 15, 2009, at 2:36 PM, Graham Barr wrote: >>>>> On Sep 4, 2009, at 2:40 PM, Quanah Gibson-Mount wrote: >>>>>> Just curious... I see no commits to git since 10/2008. I sent a >>>>>> private email a while back about a nasty issue with >>>>>> Net::LDAP::LDIF >>>>>> when used with UTF8 characters. >>>>> >>>>> No it is not dead. Things have just been a bit crazy for me >>>>> recently. >>>>> >>>>> I obviously missed your private email. please resend. >>>> >>>> Thanks! I'll track it down today and resend it. And I completely >>>> understand about times getting crazy. ;) >>> >>> Ok, I resent the email yesterday. Can you confirm you received >>> it? :) >> >> Yes I got it. Seems a strange situation but I will try to look at >> it this week. > > Quanah, > > I took a look at your example. The issue is that the DN has non- > ascii characters in it, but the encode option to Net::LDAP::LDIF is > left at thte default value of 'none'. 'none' seems an odd default as > it can generate invalid output. I think it was meant more for quick > debugging output as base64 hides the data. 'base64' would seem a > more reasonable default to me. > > Chris, You made this code change back in 2001 > > http://github.com/gbarr/perl-ldap/commit/234d7da34091ade7286593730eaf55267fc6eb41 > > It was a long time ago so you probably cannot remember why you chose > 'none', but would you not agree that 'base64' is a better default ? I would agree that base64's safer, but I'm not sure I wrote that bit of code. Change the default to base64 IMHO. Cheers, Chris