bug in LDAP 0.63

THOMAS GUEVIN <[email protected]> Mon, 16 Jun 2014 22:26:57 +0000
Newsgroups gmane.comp.lang.perl.modules.ldap
Message-ID <[email protected]>
--_000_F1516914E9171D4893DF580AA76812FE7AA215AAexmb1corpadtran_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Here is the diff of the change from 0.62 to 0.63.  There is an extra "defin=
ed" in the code.

--- /usr/local/share/perl/5.14.2/Net/LDAP.pm       2014-06-11 12:13:09.7800=
74484 +0000
+++ /usr/local/share/perl/5.14.2/Net/LDAP.pm       2014-06-11 12:13:09.7800=
74484 +0000
@@ -35,7 +35,7 @@
                           ? 'IO::Socket::INET6'
                           : '';

-our $VERSION   =3D '0.62';
+our $VERSION   =3D '0.63';
our @ISA       =3D qw(Tie::StdHash Net::LDAP::Extra);
our $LDAP_VERSION      =3D 3;      # default LDAP protocol version

@@ -251,7 +251,8 @@
   }

   (
-    SSL_cipher_list     =3D> defined $arg->{ciphers} ? $arg->{ciphers} : '=
ALL',
+    defined $arg->{ciphers} ?
+        ( SSL_cipher_list     =3D> defined $arg->{ciphers}) : (),
     SSL_ca_file         =3D> exists  $arg->{cafile}  ? $arg->{cafile}  : '=
',
     SSL_ca_path         =3D> exists  $arg->{capath}  ? $arg->{capath}  : '=
',
     SSL_key_file        =3D> $clientcert ? $clientkey : undef,


Please address in 0.64 if possible.

Thanks,

-Tom G.

--_000_F1516914E9171D4893DF580AA76812FE7AA215AAexmb1corpadtran_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri","sans-serif";}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"EN-US" link=3D"blue" vlink=3D"purple">
<div class=3D"WordSection1">
<p class=3D"MsoNormal">Here is the diff of the change from 0.62 to 0.63.&nb=
sp; There is an extra &#8220;defined&#8221; in the code.
<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">--- /usr/local/share/perl/5.14.2/Net/LDAP.pm&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp; 2014-06-11 12:13:09.780074484 &#43;0000<o:p></=
o:p></p>
<p class=3D"MsoNormal">&#43;&#43;&#43; /usr/local/share/perl/5.14.2/Net/LDA=
P.pm&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 2014-06-11 12:13:09.780074484 &#43=
;0000<o:p></o:p></p>
<p class=3D"MsoNormal">@@ -35,7 &#43;35,7 @@<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ? 'IO::Socket::INET6'<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : '';<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">-our $VERSION&nbsp;&nbsp; =3D '0.62';<o:p></o:p></p>
<p class=3D"MsoNormal">&#43;our $VERSION&nbsp;&nbsp; =3D '0.63';<o:p></o:p>=
</p>
<p class=3D"MsoNormal">our @ISA&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =3D qw(=
Tie::StdHash Net::LDAP::Extra);<o:p></o:p></p>
<p class=3D"MsoNormal">our $LDAP_VERSION&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =3D =
3;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; # default LDAP protocol version<o:p></o:p>=
</p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">@@ -251,7 &#43;251,8 @@<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp; }<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp; (<o:p></o:p></p>
<p class=3D"MsoNormal">-&nbsp;&nbsp;&nbsp; SSL_cipher_list&nbsp;&nbsp;&nbsp=
;&nbsp; =3D&gt; defined $arg-&gt;{ciphers} ? $arg-&gt;{ciphers} : 'ALL',<o:=
p></o:p></p>
<p class=3D"MsoNormal">&#43;&nbsp;&nbsp;&nbsp; defined $arg-&gt;{ciphers} ?=
<o:p></o:p></p>
<p class=3D"MsoNormal">&#43;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ( SS=
L_cipher_list&nbsp;&nbsp;&nbsp;&nbsp; =3D&gt; <b><u><span style=3D"color:re=
d">defined</span></u></b><span style=3D"color:red">
</span>$arg-&gt;{ciphers}) : (),<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp; SSL_ca_file&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =3D&gt; exists&nbsp; $arg-&gt;{cafile}&nbs=
p; ? $arg-&gt;{cafile}&nbsp; : '',<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp; SSL_ca_path&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =3D&gt; exists&nbsp; $arg-&gt;{capath}&nbs=
p; ? $arg-&gt;{capath}&nbsp; : '',<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp; SSL_key_file&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; =3D&gt; $clientcert ? $clientkey : undef,<o:p><=
/o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Please address in 0.64 if possible.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Thanks,<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">-Tom G.<o:p></o:p></p>
</div>
</body>
</html>

--_000_F1516914E9171D4893DF580AA76812FE7AA215AAexmb1corpadtran_--