Re: Disabled, checked radiobutton being submitted [patch]

[email protected] (Adam Sjøgren)
Newsgroups gmane.comp.lang.perl.modules.lwp
Organization koldfront - analysis & revolution, Copenhagen, Denmark
Message-ID <[email protected]>
On Tue, 12 Feb 2008 10:47:30 +0100, Adam wrote:

> When I have a disabled, checked radiobutton and a hidden field, both
> with the same name, the disabled radiobutton "succeeds" and it's value
> is submitted by HTML::Form.

[... new test for that elided ...]

> Does this seem correct? If so, I will see if I can whip up a patch to
> fix it (unless someone beats me to it).

This seems to do the trick:

--- lib/HTML/Form.pm.orig       2008-02-12 11:27:05.000000000 +0100
+++ lib/HTML/Form.pm    2008-02-12 11:22:57.000000000 +0100
@@ -903,7 +903,7 @@
     my $self = shift;
     my $name = $self->{'name'};
     return unless defined $name;
-    return if $self->{disabled};
+    return if $self->disabled;
     my $value = $self->value;
     return unless defined $value;
     return ($name => $value);


  Best regards,

    Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         [email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.