Re: Encode dependency
Gisle Aas <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.lwp |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Feb 12, 2009 at 22:18, Zefram <[email protected]> wrote: > I suggest a three-part strategy: > > 0. Warn at build time if the perl version is 5.8 or later (so Encode is > possible) but Encode is either absent or exhibits this bug. > > 1. If decode() returns undef, treat it as an error. This means that, > depending on the value of the raise_error option, the method will > either return undef or die. (Currently in this situation it returns > undef even if raise_error is true.) > > 2. Skip that decoding test if Encode exhibits the bug. > > The attached patch implements this. Seems totally sane. I have now applied this patch and uploaded libwww-perl-5.824 to CPAN. --Gisle