Re: content_charset and $_
Gisle Aas <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.lwp |
|---|---|
| Message-ID | <[email protected]> |
On Jan 3, 2010, at 22:22 , Father Chrysostomos wrote:
> I came across a bug in HTTP::Message::content_charset. It has a ‘local $_’, which is unnecessary, since foreach loops already localise their topic. In fact, they do it in a safer way that is more like local *_=\do{my$x}. Using local $_ causes problems if $_ is tied. The attached patch removes the offending line and adds a test for it. This did actually occur in real code, and is not just a theoretical problem.
> <open_vsKSmGR8.txt>
Thanks. Applied as <http://github.com/gisle/libwww-perl/commit/0d33cd81894ed02f7005ca742206e90511338880>.
--Gisle