Re: Spaces is message ids

* Elizabeth Mattijsen ([email protected]) [040522 21:48]:
> At 10:52 +0000 5/21/04, Rich Caller wrote:
>> What was happening was that some messages where not being read 
>> properly.  A bit of investigation indicated that these where 
>> messages where the message id contained a space and was not 
>> contained in <> and that the point of failure was the find method. 
>> A quick check of the relevent messages seemed to indicate that 
>> spaces where being replaces by +.

So, the Message-ID is in violation with RFC, which states
 msg-id = [CFWS] "<" id-left "@" id-right ">" [CFWS]

(CFWS=comments and/or folding white-spaces)
They require < >, blanks explicitly not allowed.

> Mark's on holiday for the next few weeks.

Well... sadly only one week...

> Your fix seems to be in order, on casual inspection.  However, I 
> wonder whether spaces are allowed in message ID's at all.  And if 
> they're not, the question becomes whether Mail::Box should adher to 
> the RFC's, or should adapt to what's really out there.

From the policy "produce strict compliant, accept what you can", your
patch seems sound.  Although... in this case we follow the behavior
of some client which translates blanks to '+', and I do not know whether
more clients do the same (or do it differently).  Patch accepted.
-- 
               MarkOv

------------------------------------------------------------------------
drs Mark A.C.J. Overmeer                                MARKOV Solutions
       [email protected]                          [email protected]
http://Mark.Overmeer.net                   http://solutions.overmeer.net