Re: Fixed preservation of custom install_paths on resume (RT#41166)
"David E. Wheeler" <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.module-build |
|---|---|
| Message-ID | <[email protected]> |
On Aug 19, 2009, at 8:33 AM, David Golden wrote: > New way: Default install paths are generated "on demand" based on > whatever > config values are in force and are not stored in the object. > Accessors for all > the install path properties now merge custom install paths in object > properties with the generated defaults on the fly. Among other > things, this > allows config values to be changed programatically after object > construction > and change the resulting install paths. > > There is a subtle semantic change in that setting an install path to > "undef" > stores that in the object properties. This ensures the generated > default > is masked, giving an "undef" result. (The old way deleted the > install path > from the object properties.) I think the end result is the same -- > asking > for a "deleted" path returns an undef value. This sounds completely reasonable to me. I've added a [comment](http://github.com/SamuraiJack/module-build-jsan/commit/bb3842316052fdcf2240ca545f200b3745c724de#comment_27710 ) to a GitHub commit to Module::Build::JSAN that I know is relevant. Hopefully Nickolay can give your modifications a try with his fork of Module::Build::JSAN. Best, David