Re: [svn:Module-Build] r13222 - in Module-Build/trunk: . t

Eric Wilhelm <[email protected]>
Newsgroups gmane.comp.lang.perl.modules.module-build
Message-ID <[email protected]>
# from [email protected]
# on Tuesday 25 August 2009 13:30:

>Log:
>Fix t/destinations.t segfault on 5.6.2

>-    local $mb->install_sets->{site} = \%test_config;
>+    my $old =  $mb->install_sets->{site} = \%test_config;
...
>+    $mb->install_sets->{site} = $old;

Hi David,

Is that really what you intended?  The log sounds like you wanted to 
workaround a local() bug, but this code changes the value of site 
rather than restoring it.

--Eric
-- 
"Everything should be made as simple as possible, but no simpler."
--Albert Einstein
---------------------------------------------------
    http://scratchcomputing.com
---------------------------------------------------
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.