Re: [svn:Module-Build] r13222 - in Module-Build/trunk: . t

David Golden <[email protected]>
Newsgroups gmane.comp.lang.perl.modules.module-build
Message-ID <[email protected]>
On Thu, Aug 27, 2009 at 6:39 PM, Eric Wilhelm<[email protected]> wrote:
> # from [email protected]
> # on Tuesday 25 August 2009 13:30:
>
>>Log:
>>Fix t/destinations.t segfault on 5.6.2
>
>>-    local $mb->install_sets->{site} = \%test_config;
>>+    my $old =  $mb->install_sets->{site} = \%test_config;
> ...
>>+    $mb->install_sets->{site} = $old;
>
> Hi David,
>
> Is that really what you intended?  The log sounds like you wanted to
> workaround a local() bug, but this code changes the value of site
> rather than restoring it.

Bah.  Not what I intended.  Tests pass, though.  :-)

Thanks for spotting my haste/stupidity.

-- David
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.