Re: How should a failing TAP::Harness result exit?
"David E. Wheeler" <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.module-build |
|---|---|
| Message-ID | <[email protected]> |
On August 31, 2009 at 13:28, David Golden wrote:
> David Wheeler opened a ticket on Module::Build noting that
> Test::Harness dies on failure but TAP::Harness does not. Thus, "Build
> test" with TAP::Harness active could have exit code 0 (success) even
> if things failed.
>
> My response was to add the same die message that is generated by
> Test::Harness to Module::Build when running under TAP::Harness and the
> resulting Aggregator object had errors.
>
> David's concern is that TAP::Harness already has a summary and that
> adding another summary in the die message is redundant. My view is
> that there is no way to know what kind of summary is produced by any
> given TAP formatter and that mimicking Test::Harness provides
> "belt
> and suspenders" coverage to ensure a sensible exit message on
> failure.
>
> Alternatively, I could have Module::Build just die("Errors in testing.
> Cannot continue\n") instead of emulating the Test::Harness die
> message.
>
> Thoughts?
>
> David
>
> P.S. See https://rt.cpan.org/Ticket/Display.html?id=49080 for ticket
> history
Really? No one has an opinion on this? I think the last option might
be the best, personally.
Best,
David