barcode128 encoding fix when a transition is required from type C to type B [1 Attachment]
Doru Petrescu <[email protected]> Fri, 11 Dec 2009 23:53:54 +0200
| Newsgroups | gmane.comp.lang.perl.modules.pdfapi2 |
|---|---|
| Message-ID | <1260568434.26752.13570.camel@localhost> |
--w9dIxabuxNZZg-EbPHvFab7De83XnSwRxlNBIpG
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Hi All,
I found a problem while trying to encode a barcode using the CODE128
type C that at some point included some letters.
The encoder failed to properly switch from type C to type B for some
codes while working for others.
I've located the problem in
PDF/API2/Resource/XObject/Form/BarCode/code128.pm function
encode_128_string()
For example if you try to encode this code: "01234ABC"
it will encode
- "01" pair as type C
- "23" pair as type C
- will find "4" as a single digit followed by non-digit and properly
switch to type B
- encode "4" as type B
- encode "A" as type B
- encode "B" as type B
- encode "C" as type B
but it will fail to properly encode this code: "0123ABCD"
it will encode:
- "01" pair as type C
- "23" pair as type C
- will retrieve "A" and check if it is a digit followed by something else ... and is NOT
- will try to encode "A" as type C ... and produce some garbage
- will try to encode "B" as type C ... and produce some garbage
- will try to encode "C" as type C ... and produce some garbage
- will try to encode "D" as type C ... and produce some garbage
I attach a patch with a fix.
Best Regards,
Doru Theodor Petrescu
CTO, EVOX Solutions
http://evox.ro/
--w9dIxabuxNZZg-EbPHvFab7De83XnSwRxlNBIpG
Content-Type: text/html; charset=US-ASCII
Content-Transfer-Encoding: 7bit
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
</head>
<body style="background-color: #fff;">
<span style="display:none"> </span>
<!--~-|**|PrettyHtmlStartT|**|-~-->
<div id="ygrp-mlmsg" style="position:relative;">
<div id="ygrp-msg" style="z-index: 1;">
<!--~-|**|PrettyHtmlEndT|**|-~-->
<div id="ygrp-text" >
<!--~-|**|PrettyHtmlStart|**|-~-->
<span style="font-weight: 700; font-size: 12px; display: block; margin-bottom: 20px;">[<a style="text-decoration: none;" href="#TopText">Attachment(s)</a> from Doru Petrescu included below]</span>
<!--~-|**|PrettyHtmlEnd|**|-~-->
<p>Hi All,<br>
<br>
I found a problem while trying to encode a barcode using the CODE128<br>
type C that at some point included some letters. <br>
The encoder failed to properly switch from type C to type B for some<br>
codes while working for others.<br>
<br>
I've located the problem in<br>
PDF/API2/Resource/<wbr>XObject/Form/<wbr>BarCode/code128.<wbr>pm function<br>
encode_128_string(<wbr>)<br>
<br>
For example if you try to encode this code: "01234ABC"<br>
it will encode<br>
- "01" pair as type C<br>
- "23" pair as type C<br>
- will find "4" as a single digit followed by non-digit and properly<br>
switch to type B<br>
- encode "4" as type B<br>
- encode "A" as type B<br>
- encode "B" as type B<br>
- encode "C" as type B<br>
<br>
but it will fail to properly encode this code: "0123ABCD"<br>
it will encode:<br>
- "01" pair as type C<br>
- "23" pair as type C<br>
- will retrieve "A" and check if it is a digit followed by something else ... and is NOT<br>
- will try to encode "A" as type C ... and produce some garbage<br>
- will try to encode "B" as type C ... and produce some garbage<br>
- will try to encode "C" as type C ... and produce some garbage<br>
- will try to encode "D" as type C ... and produce some garbage<br>
<br>
I attach a patch with a fix.<br>
<br>
Best Regards,<br>
Doru Theodor Petrescu<br>
CTO, EVOX Solutions<br>
<a href="http://evox.ro/">http://evox.<wbr>ro/</a><br>
<br>
</p>
</div>
<!--~-|**|PrettyHtmlStart|**|-~-->
<div style="color: #fff; height: 0;">__._,_.___</div>
<a name="TopText"><p style="clear: both; margin: 0 0; padding: 0 0 3px 0;"><span style="color: #628C2A; font-weight: 700; font-size: 13px;">Attachment(s) from Doru Petrescu</span></p></a>
<p id="attach-count" style="margin: 0 0 2px 0; padding: 10px 0 0 0;"><span style="color: #628C2A; font-weight: 700;"> 1 of 1 File(s) </span>
</p>
<div class="attach-table">
<div class="file-row" style="clear: both; margin: 2px 0; white-space: nowrap; float: left; margin: 2px 0;">
<div class="ygrp-file-title"> <img src="http://us.i1.yimg.com/us.yimg.com/i/yg/img/doc/text16x16.gif" style="margin-right: 5px; vertical-align: middle;"> <a style="text-decoration: none;" href="http://d.yimg.com/kq/groups/2017382/1342554155/name/patch-fix-code128-transition-from-c-to-b" title="patch-fix-code128-transition-from-c-to-b">patch-fix-code128-transition-from-c-to-b</a></div>
</div>
</div>
<div id="ygrp-actbar" style="clear: both; margin-bottom: 10px; white-space: nowrap; color: #666; padding-top: 15px;">
<div>
<a href="mailto:?subject=barcode128 encoding fix when a transition is required from type C to type B">
Reply to <span style="font-weight: 700;">sender</span></a>
| <a href="mailto:[email protected]?subject=barcode128 encoding fix when a transition is required from type C to type B">
Reply to <span style="font-weight: 700;">group</span></a>
</div>
<a href="http://groups.yahoo.com/group/perl-text-pdf-modules/message/3698;_ylc=X3oDMTM0aW5pajNsBF9TAzk3MzU5NzE0BGdycElkAzIwMTczODIEZ3Jwc3BJZAMxNzA1MDA3NzA5BG1zZ0lkAzM2OTgEc2VjA2Z0cgRzbGsDdnRwYwRzdGltZQMxMjYwNjE4MjYzBHRwY0lkAzM2OTg-">Messages in this topic</a>
(<span style="font-weight: 700;">1</span>)
</div>
<!------- Start Nav Bar ------>
<!-- |**|begin egp html banner|**| -->
<!-- |**|end egp html banner|**| -->
<!-- |**|begin egp html banner|**| -->
<div id="ygrp-vital" style="background-color: #e0ecee; font-family: Verdana; font-size: 10px; margin-bottom: 10px; padding: 10px;">
<span id="vithd" style="font-weight: bold; color: #333; text-transform: uppercase; ">Recent Activity:</span>
<ul style="list-style-type: none; margin: 0; padding: 0; display: inline;">
<li style="border-right: 1px solid #000; font-weight: 700; display: inline; padding: 0 5px; margin-left: 0;">
<span class="cat"><a href="http://groups.yahoo.com/group/perl-text-pdf-modules/members;_ylc=X3oDMTJmbGdtbXRuBF9TAzk3MzU5NzE0BGdycElkAzIwMTczODIEZ3Jwc3BJZAMxNzA1MDA3NzA5BHNlYwN2dGwEc2xrA3ZtYnJzBHN0aW1lAzEyNjA2MTgyNjM-?o=6" style="text-decoration: none;">New Members</a></span>
<span class="ct" style="color: #ff7900;">2</span>
</li>
</ul>
<div style="clear: both; padding-top: 2px; color: #1e66ae;">
<a href="http://groups.yahoo.com/group/perl-text-pdf-modules;_ylc=X3oDMTJlcjAxNTVrBF9TAzk3MzU5NzE0BGdycElkAzIwMTczODIEZ3Jwc3BJZAMxNzA1MDA3NzA5BHNlYwN2dGwEc2xrA3ZnaHAEc3RpbWUDMTI2MDYxODI2Mw--" style="border-right: 1px solid #000; padding-right: 5px; margin-right: 2px; text-decoration: none;">Visit Your Group</a>
<a href="http://groups.yahoo.com/group/perl-text-pdf-modules/post;_ylc=X3oDMTJlcGNpcXM5BF9TAzk3MzU5NzE0BGdycElkAzIwMTczODIEZ3Jwc3BJZAMxNzA1MDA3NzA5BHNlYwNmdHIEc2xrA250cGMEc3RpbWUDMTI2MDYxODI2Mw--" style="font-weight: 700; text-decoration: none;">Start a New Topic</a>
</div>
</div>
<div id="ygrp-grft" style="font-family: Verdana; font-size: 12px; padding: 15px 0;">
<!-- |**|begin egp html banner|**| -->
To unsubscribe from this group, send an email to:<BR>
perl-text-pdf-modules-unsubscribe-Km8ibD4bFueDmjp1MlKEbA@public.gmane.org<BR>
<BR>
<!-- |**|end egp html banner|**| -->
</div>
<div id="ygrp-mkp" style="border: 1px solid #d8d8d8; clear: both; float: left; font-family: Arial; margin: 5px 0 10px 0; padding: 0 10px;">
<div id="hd" style="color: #628c2a; font-size: 85%; font-weight: 700; line-height: 122%; margin: 10px 0;">MARKETPLACE</div>
<div id="ads" style="margin-bottom: 10px;">
<div class="ad" style="color: #628C2A; font-family: Arial; font-weight: 700; padding: 0 0;">
<p><a href="http://us.ard.yahoo.com/SIG=14kus1t9t/M=493064.13814333.13821539.13298430/D=groups/S=1705007709:MKP1/Y=YAHOO/EXP=1260625464/L=/B=qGI8DkSO5_Q-/J=1260618264473756/K=N5AK3HqyFjtcsIPD9cGOJw/A=5922843/R=0/SIG=11ckn2mo6/*http://advision.webevents.yahoo.com/green/">Going Green: Your Yahoo! Groups resource for green living</a></p> </div>
<div class="ad" style="color: #628C2A; font-family: Arial; font-weight: 700; padding: 0 0;">
<hr style="border: 1px solid #d8d8d8;">
<p><a href="http://us.ard.yahoo.com/SIG=14k126b7m/M=493064.13814537.13821737.10835568/D=groups/S=1705007709:MKP1/Y=YAHOO/EXP=1260625464/L=/B=qWI8DkSO5_Q-/J=1260618264473756/K=N5AK3HqyFjtcsIPD9cGOJw/A=5922843/R=0/SIG=11ckn2mo6/*http://advision.webevents.yahoo.com/green/">Going Green: Your Yahoo! Groups resource for green living</a></p> </div>
</div>
</div>
<div id="ft" style="font-family: Arial; font-size: 11px; margin-top: 5px; padding: 0 2px 0 0; clear: both;">
<a href="http://groups.yahoo.com/;_ylc=X3oDMTJkaHFiZWtqBF9TAzk3MzU5NzE0BGdycElkAzIwMTczODIEZ3Jwc3BJZAMxNzA1MDA3NzA5BHNlYwNmdHIEc2xrA2dmcARzdGltZQMxMjYwNjE4MjYz" style="float: left;"><img src="http://l.yimg.com/a/i/us/yg/logo/us.gif" height="15" width="137" alt="Yahoo! Groups" style="border: 0;"/></a>
<div style="color: #747575; float: right;">Switch to: <a href="mailto:perl-text-pdf-modules-traditional-hHKSG33TihhbjbujkaE4pw@public.gmane.org?subject=Change Delivery Format: Traditional" style="text-decoration: none;">Text-Only</a>, <a href="mailto:perl-text-pdf-modules-digest-hHKSG33TihhbjbujkaE4pw@public.gmane.org?subject=Email Delivery: Digest" class="margin-rt" style="text-decoration: none;">Daily Digest</a> • <a href="mailto:perl-text-pdf-modules-unsubscribe-hHKSG33TihhbjbujkaE4pw@public.gmane.org?subject=Unsubscribe" style="text-decoration: none;">Unsubscribe</a> • <a href="http://docs.yahoo.com/info/terms/" style="text-decoration: none;">Terms of Use</a></div>
</div>
<!-- |**|end egp html banner|**| -->
</div> <!-- ygrp-msg -->
<!-- Sponsor -->
<!-- |**|begin egp html banner|**| -->
<div id="ygrp-sponsor" style="width:160px; float:right; clear:none; margin:0 0 25px 0; background: #fff;">
<!-- Start Recommendations -->
<div id="ygrp-reco">
</div>
<!-- End Recommendations -->
</div> <!-- |**|end egp html banner|**| -->
<div style="clear:both; color: #FFF; font-size:1px;">.</div>
</div>
<img src="http://geo.yahoo.com/serv?s=97359714/grpId=2017382/grpspId=1705007709/msgId=3698/stime=1260618263/nc1=3848644/nc2=3848583/nc3=5170417" width="1" height="1"> <br>
<div style="color: #fff; height: 0;">__,_._,___</div>
<!--~-|**|PrettyHtmlEnd|**|-~-->
</body>
<!--~-|**|PrettyHtmlStart|**|-~-->
<head>
<style type="text/css">
<!--
#ygrp-mkp {
border: 1px solid #d8d8d8;
font-family: Arial;
margin: 10px 0;
padding: 0 10px;
}
#ygrp-mkp hr {
border: 1px solid #d8d8d8;
}
#ygrp-mkp #hd {
color: #628c2a;
font-size: 85%;
font-weight: 700;
line-height: 122%;
margin: 10px 0;
}
#ygrp-mkp #ads {
margin-bottom: 10px;
}
#ygrp-mkp .ad {
padding: 0 0;
}
#ygrp-mkp .ad a {
color: #0000ff;
text-decoration: none;
}
#ygrp-sponsor #ygrp-lc {
font-family: Arial;
}
#ygrp-sponsor #ygrp-lc #hd {
margin: 10px 0px;
font-weight: 700;
font-size: 78%;
line-height: 122%;
}
#ygrp-sponsor #ygrp-lc .ad {
margin-bottom: 10px;
padding: 0 0;
}
a {
color: #1e66ae;
}
#actions {
font-family: Verdana;
font-size: 11px;
padding: 10px 0;
}
#activity {
background-color: #e0ecee;
float: left;
font-family: Verdana;
font-size: 10px;
padding: 10px;
}
#activity span {
font-weight: 700;
}
#activity span:first-child {
text-transform: uppercase;
}
#activity span a {
color: #5085b6;
text-decoration: none;
}
#activity span span {
color: #ff7900;
}
#activity span .underline {
text-decoration: underline;
}
.attach {
clear: both;
display: table;
font-family: Arial;
font-size: 12px;
padding: 10px 0;
width: 400px;
}
.attach div a {
text-decoration: none;
}
.attach img {
border: none;
padding-right: 5px;
}
.attach label {
display: block;
margin-bottom: 5px;
}
.attach label a {
text-decoration: none;
}
blockquote {
margin: 0 0 0 4px;
}
.bold {
font-family: Arial;
font-size: 13px;
font-weight: 700;
}
.bold a {
text-decoration: none;
}
dd.last p a {
font-family: Verdana;
font-weight: 700;
}
dd.last p span {
margin-right: 10px;
font-family: Verdana;
font-weight: 700;
}
dd.last p span.yshortcuts {
margin-right: 0;
}
div.attach-table div div a {
text-decoration: none;
}
div.attach-table {
width: 400px;
}
div.file-title a, div.file-title a:active, div.file-title a:hover, div.file-title a:visited {
text-decoration: none;
}
div.photo-title a, div.photo-title a:active, div.photo-title a:hover, div.photo-title a:visited {
text-decoration: none;
}
div#ygrp-mlmsg #ygrp-msg p a span.yshortcuts {
font-family: Verdana;
font-size: 10px;
font-weight: normal;
}
.green {
color: #628c2a;
}
.MsoNormal {
margin: 0 0 0 0;
}
o {
font-size: 0;
}
#photos div {
float: left;
width: 72px;
}
#photos div div {
border: 1px solid #666666;
height: 62px;
overflow: hidden;
width: 62px;
}
#photos div label {
color: #666666;
font-size: 10px;
overflow: hidden;
text-align: center;
white-space: nowrap;
width: 64px;
}
#reco-category {
font-size: 77%;
}
#reco-desc {
font-size: 77%;
}
.replbq {
margin: 4px;
}
#ygrp-actbar div a:first-child {
/* border-right: 0px solid #000;*/
margin-right: 2px;
padding-right: 5px;
}
#ygrp-mlmsg {
font-size: 13px;
font-family: Arial, helvetica,clean, sans-serif;
*font-size: small;
*font: x-small;
}
#ygrp-mlmsg table {
font-size: inherit;
font: 100%;
}
#ygrp-mlmsg select, input, textarea {
font: 99% Arial, Helvetica, clean, sans-serif;
}
#ygrp-mlmsg pre, code {
font:115% monospace;
*font-size:100%;
}
#ygrp-mlmsg * {
line-height: 1.22em;
}
#ygrp-mlmsg #logo {
padding-bottom: 10px;
}
#ygrp-mlmsg a {
color: #1E66AE;
}
#ygrp-msg p a {
font-family: Verdana;
}
#ygrp-msg p#attach-count span {
color: #1E66AE;
font-weight: 700;
}
#ygrp-reco #reco-head {
color: #ff7900;
font-weight: 700;
}
#ygrp-reco {
margin-bottom: 20px;
padding: 0px;
}
#ygrp-sponsor #ov li a {
font-size: 130%;
text-decoration: none;
}
#ygrp-sponsor #ov li {
font-size: 77%;
list-style-type: square;
padding: 6px 0;
}
#ygrp-sponsor #ov ul {
margin: 0;
padding: 0 0 0 8px;
}
#ygrp-text {
font-family: Georgia;
}
#ygrp-text p {
margin: 0 0 1em 0;
}
#ygrp-text tt {
font-size: 120%;
}
#ygrp-vital ul li:last-child {
border-right: none !important;
}
-->
</style>
</head>
<!--~-|**|PrettyHtmlEnd|**|-~-->
</html>
<!-- end group email -->
--w9dIxabuxNZZg-EbPHvFab7De83XnSwRxlNBIpG--