Re: [blead 2009-05-29.22:08:17] vms.c EFS logical name fix.
"Craig A. Berry" <[email protected]>
| Newsgroups | gmane.comp.lang.perl.ports.vms |
|---|---|
| Message-ID | <[email protected]> |
On Jun 4, 2009, at 7:00 PM, John E. Malmberg wrote: > Craig A. Berry wrote: >> On Thu, Jun 4, 2009 at 9:18 AM, Craig A. Berry <[email protected]> >> wrote: >>> On Jun 4, 2009, at 8:46 AM, John E. Malmberg wrote: >>> >>>> This patch fixes an issue that Craig Berry found in the handling of >>>> logical names of the form foo = "device:[dir]" when the EFS >>>> character set is >>>> enabled. >>> >>> Looks good. Can we add a test case for this? >> I went ahead and did that here: >> http://perl5.git.perl.org/perl.git/commitdiff/50255d5 > > Thanks. I did not have time to write a test this morning. I went back to my original test case (not the narrower one you ended up fixing) and it looks like we are half-way there. If both DECC $EFS_CHARSET and DECC$FILENAME_UNIX_REPORT are defined, this works: $ perl -"MFile::Spec::Functions" -e "print catfile(File::Spec- >tmpdir(), 'bar');" /sys$scratch/bar but if only DECC$EFS_CHARSET is defined, it doesn't: $ perl -"MFile::Spec::Functions" -e "print catfile(File::Spec- >tmpdir(), 'bar');" [.sys$scratch:]bar ____________________ Craig A. Berry mailto:[email protected] "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser