Re: HTTPLoop.RequestProgram.not_query

Thank you for your reply.

Chris Angelico <[email protected]> writes:

> On Wed, Feb 3, 2016 at 8:45 PM, Eiichiro ITANI <[email protected]> wrote:

> Still exists in 8.1. Looks like the fix is simple though. Edit
> src/modules/HTTPLoop/requestobject.c line 187 and remove the +1 from
> the last argument - I'm pretty sure it's never going to want that +1.
> Incidentally, there's an entirely unused 'begin' variable there - it's
> initialized to zero and never changed, and then it's used as some sort
> of offset.

At 9d2f24bdfefe0990480835222ff9eefe62f7c535, Mr. Per Hedbor removed
roxen prestate handling.  Removed code contains line "j--".  So this
problem has occurred since 2014.


> I would be inclined to fix this on 8.0 and 8.1, except that that code
> hasn't changed since 1999 (according to 'git blame') and nobody else
> has reported an issue. So either nobody's using this, or there's
> something somewhere else that means this does actually work.

I'll bet on the former ;-)

--
  ITANI Eiichiro