[ruby-core:95914] [Ruby master Bug#16361] TestEnv#test_fetch failure

Issue #16361 has been updated by mame (Yusuke Endoh).


How did you run the test?  Currently, bundled gems should be unavailable in `make test-all`, and some tests don't assume that bundled gems are loaded.

Currently, did_you_mean is a bundled gem, so should not be loaded in `make test-all`.  [test/optparse/test_did_you_mean.rb](https://github.com/ruby/ruby/blob/818708edab6e950a8c1828816b73d36f05585f9f/test/optparse/test_did_you_mean.rb#L3) is disabled in effect: `require "did_you_mean" rescue return`.  So this test file should not be loaded in the whole test suite run.

We plan to convert did_you_mean to a default gem.  Until the conversion, the test file will be disabled.

----------------------------------------
Bug #16361: TestEnv#test_fetch failure
https://bugs.ruby-lang.org/issues/16361#change-82754

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.7.0dev (2019-11-22 master f9d20a1bf1) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
I am facing following test suite error:

~~~
  1) Failure:
TestEnv#test_fetch [/builddir/build/BUILD/ruby-2.7.0-f9d20a1bf1/test/ruby/test_env.rb:123]:
[ruby-core:56062] [Feature #8649].
Expected Exception(KeyError) was raised, but the message doesn't match.
<"key not found: \"test\""> expected but was
<"key not found: \"test\"\n" + "Did you mean?  \"TESTS\"">.
~~~

Trying to execute this test independently, it passes just fine. So it seems that the did_you_mean gem is loaded unexpectedly on this place. I just tried:

~~~
mv test/optparse/test_did_you_mean.rb{,.bak}
~~~

since this is the latest addition IMO and the test suite passes just fine.

I am not really sure why it should fail on my setup and it probably does not fail in any other CI. Neither I am sure what would be the best option to fix this. The assertion could be updated to accept this message by simple sed:

~~~
sed -i "/'key not found: \"test\"'/ s/'/\//g" test/ruby/test_env.rb
~~~



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>