[ruby-core:96047] Re: [ruby-trunk - Feature #9602] Logic with `Enumerable#grep`

John W Higgins <[email protected]>
Newsgroups gmane.comp.lang.ruby.core
Message-ID <CAPhAwGwVfG=Xx=swGiW4kMD=MuoBwJba7J=xw9cXc6duFkgTEw@mail.gmail.com>
On Tue, Apr 1, 2014 at 8:50 PM <[email protected]> wrote:

> Issue #9602 has been updated by Sam Rawlins.
>
>
> I've updated my patch some more with Enumerable#reject and Array#reject.
> (Array#reject was weird... I reabsorbed `ary_reject()` into
> `rb_ary_reject()` and left the only use of `rb_ary_push_1()` intact. I
> think some of this code was very old.)
>
>
This looks excellent - but the docs for reject changed the following

"... for which the given block is not true"

to

".. for which the given block returns a false value"

I think the "not true" wording may be better because nils are caught in the
reject code.

Thanks again for the work - it looks excellent.

John


Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.