[ruby-core:96266] [Ruby master Bug#15425] Store MJIT header into Ruby versioned directory.

[email protected]
Newsgroups gmane.comp.lang.ruby.core
Message-ID <redmine.journal-83163.20191216135051.7b1646b21e64f427@ruby-lang.org>
Issue #15425 has been updated by nobu (Nobuyoshi Nakada).


Why is this needed?
It seems having no effects.

```diff
--- a/configure.ac
+++ b/configure.ac
@@ -3096,9 +3096,6 @@ AC_ARG_ENABLE(multiarch,
 	      [multiarch=], [unset multiarch])
 AS_IF([test ${multiarch+set}], [
    AC_DEFINE(ENABLE_MULTIARCH)
-   MJIT_HEADER_INSTALL_DIR=include/'${arch}/${RUBY_VERSION_NAME}'
-], [
-   MJIT_HEADER_INSTALL_DIR=include/'${RUBY_VERSION_NAME}/${arch}'
 ])
 
 archlibdir='${libdir}/${arch}'
@@ -3772,6 +3769,12 @@ AS_IF([test "${LOAD_RELATIVE+set}"], [
     RUBY_EXEC_PREFIX=''
 ])
 
+AS_IF([test ${multiarch+set}], [
+   MJIT_HEADER_INSTALL_DIR=include/'${arch}/${RUBY_VERSION_NAME}'
+], [
+   MJIT_HEADER_INSTALL_DIR=include/'${RUBY_VERSION_NAME}/${arch}'
+])
+
 AC_SUBST(RUBY_EXEC_PREFIX)
 
 AC_SUBST(libdirname, ${multiarch+arch}libdir)
```

----------------------------------------
Bug #15425: Store MJIT header into Ruby versioned directory.
https://bugs.ruby-lang.org/issues/15425#change-83163

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 
* ruby -v: ruby 2.6.0rc2 (2018-12-15 trunk 66408) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
This is a followup of #15391 which fixes JIT to respect the configuration options. However, I still wonder, why the file is versioned and why it is not stored in the versioned directory alongside all other internal Ruby headers. I believe, that while it now respects the header configuration flags, it still does not respect options such as "--with-ruby-version"

---Files--------------------------------
0001-Store-MJIT-header-into-Ruby-versioned-directory-2.patch (1.8 KB)
0001-Store-MJIT-header-into-Ruby-versioned-directory-1.patch (1.72 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.