[ruby-core:96818] [Ruby master Misc#16507] =~ vs include? or match?

[email protected] Sun, 12 Jan 2020 23:27:07 +0000 (UTC)
Newsgroups gmane.comp.lang.ruby.core
Message-ID <redmine.issue-16507.20200112232707.259e04ccb584a0c3@ruby-lang.org>
Issue #16507 has been reported by MSP-Greg (Greg L).

----------------------------------------
Misc #16507: =~ vs include? or match?
https://bugs.ruby-lang.org/issues/16507

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
While working on getting the mswin build working on Actions, I thought adding mswin? and ci? methods to Minitest::Unit::Guard in tool/lib/minitest/unit.rb would be helpful.

Currently some tests are failing that are guarded/skipped based on ENV['APPVEYOR'].  For ci?, I'd combine Travis, AppVeyor, & Actions.

There are quite a few instances where =~ is used for a boolean return.  Would it be considered appropriate to replace those calls with include? or match? 



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>