Re: [PATCH] prims: Bit-and the flags instead of using boolean operation

Il 13/09/2014 20:58, Holger Hans Peter Freyther ha scritto:
> On Sat, Sep 13, 2014 at 08:25:24PM +0200, Holger Hans Peter Freyther wrote:
> 
> Dear Paolo,
> 
> 
> 
>> This was pointed out by the clang compiler. Current access can
>> be either 0 or 1 but I think we want to be able to pass it as
>> integer as well. It looks like this code has never been executed
>> and we might just remove the call by number.
> 
> what do you think about removing it? I added an abort to the codepath
> and ran make check. It is not hit and I don't think external code is
> calling that primitive either.

Yeah, it's not been used for several years probably, and DLD would be a
better way to hook into open(2) nowadays.

Paolo