Re: [PATCH] gst-tool: Fix ASAN issue on comparing options
Paolo Bonzini <[email protected]>
| Newsgroups | gmane.comp.lang.smalltalk.gnu.general |
|---|---|
| Message-ID | <[email protected]> |
On 08/02/2017 15:51, Holger Freyther wrote: > >> On 8 Feb 2017, at 21:50, Holger Freyther <[email protected]> wrote: >> > > > Hi! > >> In case the name is longer than all_opts->name we would try to >> read past the string. Start using strncmp and strlen to make >> sure to fully consume all_opts->name and don't read out of >> bounds. > > my inbox can't find this but I think we had this before? It is > triggered by ASAN right away. Wouldn't the '\0' mismatch first? Paolo