Re: [PATCH v2 1/4] libgst: Fix comments

Holger Freyther <[email protected]>
Newsgroups gmane.comp.lang.smalltalk.gnu.general
Message-ID <[email protected]>
> On 30. Nov 2017, at 17:31, Lee Duhem <[email protected]> wrote:
> 

Hey!



> /* Grows the allocated memory to SPACESIZE bytes, if it's not there
> -   already.  
> -   the memory could not be allocated.  Should be called after the
> -   sweep has occurred so that things are contiguous.  Ensures that the
> -   OOP table pointers are fixed up to point to the new objects.  */
> +   already. */
> extern void _gst_grow_memory_to (size_t size) 

The "sweep" doesn't seem to be enforced (scavenge before as part of
the init_mem, but if invoked through the primitive I don't see a sweep).


Mentioning "_gst_fixup_object_pointers" and that no garbage is copied
might be valuable? I will most likely apply as is but why did you
decide to remove this?

cheers
	holger
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.