Re: Harvester status for Marcus Denker

[email protected] wrote:
> I am not sure we have such different standards - but I still agree that
> we need a policy.
[snip]
> What did you mean with "read all code" - you mean instead of simply
> "trusting" someone? I always read all code I review, regardless of
> author.
Exactly - and we should make that policy, instead of something each
harvester might or might not choose to do.

> Well, it would be interesting to write down the policy somewhere - at
> least the non obvious and the mandatory stuff. I am not saying "Swiki"
> because I am a bit tired of simply creating more and more pages on the
> Swikis, but if no other smarter way is found then sure, why not.
What's wrong with the Swiki?

Daniel
From [email protected] Tue Jun 10 13:39:01 2003
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: (qmail 28186 invoked from network); 10 Jun 2003 13:39:01 -0000
Received: from mxout4.netvision.net.il (194.90.9.27)
  by mail.theinternetone.net with SMTP; 10 Jun 2003 13:39:01 -0000
Received: from aSqueakSystem ([80.178.108.51]) by mxout4.netvision.net.il
 (iPlanet Messaging Server 5.2 HotFix 1.14 (built Mar 18 2003))
 with SMTPA id <[email protected]> for
 [email protected]; Tue,
 10 Jun 2003 16:10:55 +0300 (IDT)
Date: Tue, 10 Jun 2003 15:52:05 +0200
From: Daniel Vainsencher <[email protected]>
Subject: Re: [Squeakfoundation]Harvester status for Marcus Denker
To: Discussing the Squeak Foundation
 <[email protected]>
Message-id: <[email protected]>
X-Mailer: Celeste 2.0.5174
Content-transfer-encoding: 7BIT
X-BeenThere: [email protected]
X-Mailman-Version: 2.1
Precedence: list
Reply-To: Discussing the Squeak Foundation
	<[email protected]>
List-Id: Discussing the Squeak Foundation
 <squeakfoundation.lists.squeakfoundation.org>
List-Unsubscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://lists.squeakfoundation.org/pipermail/squeakfoundation>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2003 13:39:01 -0000

Meaningfull tests for every class are a good goal, and the test server
will make them much more meaningful. OTOH, I don't think checking for a
class comment is a good use for a test, it's too wasteful. 

What I think we should do to improve these things is use SLint rules,
and have the test server run those too (in some future release, it's not
important to do this right now - most important is to start running
tests regularly). 

Daniel

Marcus Denker <[email protected]> wrote:
> There's actually a test in the Tests-package for that: I've done
> a Abstract testing-class called "ClassTestCase". 
> If you inherit from this one instead of TestCase (and name the test
> "<name of the class>Test", you get an error if the class-comment is empty.
> 
> (and you get 3 more tests: testNew, testUnCategorizedMethods, testRecompileAll)
> 
> There are not yet tests for every class in the system, but as soon as the
> testserver is running, I'l add more. 
> 
>         Marcus
> 
> -- 
> Marcus Denker [email protected]  -- Squeak! http://squeak.de
> 
> _______________________________________________
> Squeakfoundation mailing list
> [email protected]
> http://lists.squeakfoundation.org/listinfo/squeakfoundation
From [email protected] Tue Jun 10 14:29:47 2003
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: (qmail 21754 invoked from network); 10 Jun 2003 14:29:47 -0000
Received: from mail1.blackboard.com (HELO truman.dc.Blackboard.com)
	(64.124.103.135)
	by mail.theinternetone.net with SMTP; 10 Jun 2003 14:29:47 -0000
Received: from monroe.dc.Blackboard.com ([10.8.0.114]) by
	truman.dc.Blackboard.com with Microsoft SMTPSVC(5.0.2195.5329);
	Tue, 10 Jun 2003 10:28:48 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [Squeakfoundation]Harvester status for Marcus Denker
Date: Tue, 10 Jun 2003 10:28:31 -0400
Message-ID: <[email protected]>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [Squeakfoundation]Harvester status for Marcus Denker
Thread-Index: AcMvW/MvmiTYluL5RKGKvpHlwKZ02AAAGpGg
From: "Brent Vukmer" <[email protected]>
To: "Discussing the Squeak Foundation"
	<[email protected]>
Return-Path: [email protected]
X-OriginalArrivalTime: 10 Jun 2003 14:28:48.0898 (UTC)
	FILETIME=[9B81D620:01C32F5C]
X-BeenThere: [email protected]
X-Mailman-Version: 2.1
Precedence: list
Reply-To: Discussing the Squeak Foundation
	<[email protected]>
List-Id: Discussing the Squeak Foundation
 <squeakfoundation.lists.squeakfoundation.org>
List-Unsubscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://lists.squeakfoundation.org/pipermail/squeakfoundation>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2003 14:29:48 -0000



>=20
> > Well, it would be interesting to write down the policy=20
> somewhere - at=20
> > least the non obvious and the mandatory stuff. I am not=20
> saying "Swiki"=20
> > because I am a bit tired of simply creating more and more=20
> pages on the=20
> > Swikis, but if no other smarter way is found then sure, why not.
> What's wrong with the Swiki?
>=20
> Daniel

I think the main issue with the Swiki is that there is not yet a tool
that allows us to easily and quickly edit the Swiki from within Squeak.
From [email protected] Tue Jun 10 16:36:59 2003
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: (qmail 19760 invoked from network); 10 Jun 2003 16:36:59 -0000
Received: from mailhub02-skge0.unibe.ch (HELO mailhub02.unibe.ch)
	(130.92.9.53)
	by mail.theinternetone.net with SMTP; 10 Jun 2003 16:36:59 -0000
Received: from localhost (localhost [127.0.0.1])
	by mailhub02.unibe.ch (Postfix) with ESMTP
	id 528F47640E; Tue, 10 Jun 2003 18:36:59 +0200 (MEST)
Received: from mailhub02.unibe.ch ([127.0.0.1])
 by localhost (mailhub02 [127.0.0.1:10024]) (amavisd-new) with LMTP
 id 28365-01-8; Tue, 10 Jun 2003 18:36:58 +0200 (MEST)
Received: from asterix.unibe.ch (asterix.unibe.ch [130.92.64.4])
	by mailhub02.unibe.ch (Postfix) with ESMTP
	id 91A4D76423; Tue, 10 Jun 2003 18:36:58 +0200 (MEST)
Received: from emergent.de (howland [130.92.65.22])
	by asterix.unibe.ch (8.11.6+Sun/8.11.6) with ESMTP id h5AGatK18548;
	Tue, 10 Jun 2003 18:36:55 +0200 (MET DST)
Date: Tue, 10 Jun 2003 18:36:10 +0200
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
To: Discussing the Squeak Foundation
	<[email protected]>
From: Markus Gaelli <[email protected]>
In-Reply-To: <[email protected]>
Message-Id: <[email protected]>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.552)
X-Virus-checked: by University of Berne
cc: Bergel Alexandre <[email protected]>
cc: [email protected]
cc: Roel Wuyts <[email protected]>
Subject: [Squeakfoundation][Ann] Example group
X-BeenThere: [email protected]
X-Mailman-Version: 2.1
Precedence: list
Reply-To: Discussing the Squeak Foundation
	<[email protected]>
List-Id: Discussing the Squeak Foundation
 <squeakfoundation.lists.squeakfoundation.org>
List-Unsubscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://lists.squeakfoundation.org/pipermail/squeakfoundation>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2003 16:37:00 -0000

Daniel Vainsencher wrote:
> (...)
> * Maybe make class comments mandatory, and implement some automated
> check for this, so I don't forget it.
>
> What do you think?
>
* Make more examples and assertions

Examples would help us to understand code and
and to write tests.

So in addition to the KernelCleaningProject (KCP) and the
MorphCleaningProject  (MCP) I set up a wiki-page for an
Example group (Eg)

http://minnow.cc.gatech.edu/squeak/3248
--------------------------
Goals

Provide examples for most of the classes.

Vision

  If we had examples everywhere, it would be much easier to

	- test code
  	- understand code
  	- type check code
  	- compose new code in a test-driven style

Howto

  Create a category on the class-side called *Eg-example-objects
  Create your example, stored in a method exampleFoo
  Send the changeset to the list as an enhancement [Enh]

Example

	TextUrl class >> exampleSqueak
		^self new url: 'http://www.squeak.org'

	Text class >> exampleSqueakLink
		^self string: 'Squeak!' attribute: TextURL exampleSqueak

	TextMorph class >> exampleSqueakLink
		"self exampleSqueakLink openInWorld"

		^self new contents: Text exampleSqueakLink

And soon you also find out (manually though), that you are asked if
you want to open this link in a web-browser, but there is none anymore
:-/

So please, join us and let us code for making
the code more understandable and testable.
It's easy...

Cheers,

Markus