RE: [FIX] MoreWeakMsgSendFixes-nk
"Withers, Robert" <[email protected]>
| Newsgroups | gmane.comp.lang.smalltalk.squeak.foundation |
|---|---|
| Message-ID | <[email protected]> |
Ned, I just got back from xmas break this weekend, so I wasn't able to answer, earlier. I loaded it and looked at the code. This looks fine to me. I recategorized three registration methods, <nitpik/> and republished your changeset, attached here. It would be nice to keep the action map minimal, as actions commit hari-kari, due to weak references disappearing. Currently only a re-registration will minimize the stored sequence. This should prolly be a 3.5 activity. cheers, rob > -----Original Message----- > From: Ned Konz [mailto:[email protected]] > Sent: Friday, December 20, 2002 9:07 PM > To: [email protected] > Cc: Withers, Robert > Subject: Re: [FIX] MoreWeakMsgSendFixes-nk > > > I've just posted [FIX] MoreWeakMsgSendFixes-nk to the squeak-dev list. > > This needs to go into 3.4beta, since if you have an older action map > (with a MessageSend or an ActionSequence in it), a triggerEvent: will > cause a DNU. > > Apparently this was broken in CS 5005, and no one noticed it until > now. > > On the Squeak-dev list, Martin Drautzburg reported: > ----------- > MessageNotUnterstood: isReceiverOrAnyArgumentGa[rbage] (I cannot see > all of it) > > ActionSequence(Object)>>doesNotUnderstand > PasteUpMorph(Object)>>actionForEvent: > PasteUpMorph(Object)>>triggerEvent: > PasteUpMorph class >> shutDown > PasteUpMorph class (Behavior)>>shutDown: > ----------- > > Could someone look at the [FIX], please? > > Rob, does it look OK? > > Thanks, > -- > Ned Konz > http://bike-nomad.com > GPG key ID: BEEA7EFE >
MoreWeakMsgSendFixes-nk-rww.2.cs
(application/octet-stream, 3.5 KB) - not displayed