The Trunk: Monticello-ct.821.mcz

Christoph Thiede uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-ct.821.mcz

==================== Summary ====================

Name: Monticello-ct.821
Author: ct
Time: 6 July 2026, 3:23:28.631696 am
UUID: be9d0d84-c59f-48be-a3cb-52e1fcbf2faf
Ancestors: Monticello-ct.820

Repairs 'copy image versions' confirmation dialog (fixes grammar, polishes message format, improves multilingual support).
Speeds up #newerImageVersions by caching file names during querying.

=============== Diff against Monticello-ct.820 ===============

Item was changed:
  ----- Method: MCRepository>>newerImageVersions (in category 'private') -----
  newerImageVersions
  	^ Array streamContents:
+ 		[ : stream |
+ 			self cacheAllFileNamesDuring:
+ 				[ self allPackageNames do:
+ 					[ : eachPkgName | MCWorkingCopy allManagers
+ 						detect: [ : each | each packageName = eachPkgName ]
+ 						ifFound:
+ 							[ : loaded | loaded ancestors do:
+ 								[ : infoToCopy | (self includesVersionNamed: infoToCopy versionName) ifFalse:
+ 									[ (MCRepositoryGroup default versionWithInfo: infoToCopy)
+ 										ifNil: [ Warning signal: infoToCopy name , ' not found in RepositoryGroup default.' ]
+ 										ifNotNil:
+ 											[ : ver | stream nextPut: ver ] ] ] ]
+ 						ifNone: [ "Image specifies no version to copy." ] ] ] ]!
- 		[ : stream |  self allPackageNames do:
- 			[ : eachPkgName | MCWorkingCopy allManagers
- 				detect: [ : each | each packageName = eachPkgName ]
- 				ifFound:
- 					[ : loaded | loaded ancestors do:
- 						[ : infoToCopy | (self includesVersionNamed: infoToCopy versionName) ifFalse:
- 							[ (MCRepositoryGroup default versionWithInfo: infoToCopy)
- 								ifNil: [ Warning signal: infoToCopy name , ' not found in RepositoryGroup default.' ]
- 								ifNotNil:
- 									[ : ver | stream nextPut: ver ] ] ] ]
- 				ifNone: [ "Image specifies no version to copy." ] ] ]!

Item was changed:
  ----- Method: MCWorkingCopyBrowser>>copyImageVersionsSafely (in category 'actions') -----
  copyImageVersionsSafely
+ 
+ 	| imageVersions |
+ 	imageVersions := self repository newerImageVersions
+ 		ifEmpty: [^ self inform: 'Repository up to date.' translated].
+ 	(Project current uiManager
+ 		confirm: ('Do you really want to copy the following versions to <b>{1}</b>?
+ <br><br>
+ <blockquote>{2}</blockquote>' translated asTextFromHtml format:
+ 			{self repository description.
+ 			(imageVersions collect: [:ea | ea info name]) asCommaString})
+ 		title: 'Copy Image Versions' translated) ifFalse: [^ self].
+ 	
+ 	self copyImageVersions.!
- 	self repository newerImageVersions
- 		ifEmpty: [ Project current uiManager inform: 'Repository up to date.' ]
- 		ifNotEmpty:
- 			[ : imageVersions | | msg |
- 			msg := String streamContents:
- 				[ : stream | imageVersions do:
- 					[ : each | stream cr ;
- 						 nextPutAll: each info name ; nextPut: $,].
- 				stream cr ;
- 					 cr ;
- 					 nextPutAll: ' will be copied to <b>{1}</b>?' ].
- 			(Project current uiManager
- 				confirm: (msg translated format: {self repository description}) asTextFromHtml
- 				title: 'Copy Versions' translated) ifFalse: [ ^ self ].
- 			self copyImageVersions ]!

Squeak-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]