Re: The Trunk: SUnit-mt.153.mcz

Thank you! :-)

But "expected defects"? I understand that this is technically more precise, but it might be harder to associate with the #expectedFailures selector ...

Best,
Christoph


________________________________
From: [email protected] <[email protected]>
Sent: Tuesday, 07 July 2026 09:53:41
To: [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: [squeak-dev] The Trunk: SUnit-mt.153.mcz

Marcel Taeumel uploaded a new version of SUnit to project The Trunk:
http://source.squeak.org/trunk/SUnit-mt.153.mcz

==================== Summary ====================

Name: SUnit-mt.153
Author: mt
Time: 7 July 2026, 9:53:41.926646 am
UUID: 8962209e-29b1-7e4b-a994-359feba306b0
Ancestors: SUnit-ct.152

Revise SUnit-ct.152.

Note that we should use Set for all buckets, not just failures, I think.

=============== Diff against SUnit-ct.152 ===============

Item was changed:
  ----- Method: TestResult>>initialize (in category 'initialization') -----
  initialize
+
         super initialize.
+
+        "Note that expected defects can be within failures or errors."
+        passed := OrderedCollection new. "<-- includes unexpected passes"
+        failures := Set new. "<-- subset of --" timeouts := Set new.
-        passed := OrderedCollection new.
-        failures := Set new.
         errors := OrderedCollection new.
+
-        timeouts := Set new.
         timeStamp := TimeStamp now.
         durations := Dictionary new.!

Item was changed:
  ----- Method: TestResult>>printOn: (in category 'printing') -----
  printOn: aStream
         aStream
                 nextPutAll: self runCount printString;
                 nextPutAll: ' run in ';
                 nextPutAll: (Duration milliSeconds: self duration) printString;
                 nextPutAll: ', ';
                 nextPutAll: self expectedPassCount printString;
                 nextPutAll: (self expectedPassCount = 1 ifTrue: [' pass, '] ifFalse: [' passes, ']);
                 nextPutAll: self expectedDefectCount printString;
+                nextPutAll: (self expectedDefectCount = 1 ifTrue: [' expected defect, '] ifFalse: [' expected defects, ']);
-                nextPutAll: (self expectedDefectCount = 1 ifTrue: [' expected failure, '] ifFalse: [' expected failures, ']);
                 nextPutAll: self unexpectedFailureCount printString;
                 nextPutAll: (self unexpectedFailureCount = 1 ifTrue: [' failure'] ifFalse: [' failures']).
         timeouts ifNotEmpty:
                 [aStream
                         nextPutAll: ' ('; print: timeouts size;
                         nextPutAll: (timeouts size = 1 ifTrue: [' timeout)'] ifFalse: [' timeouts)'])].
         aStream
                 nextPutAll: ', ';
                 nextPutAll: self unexpectedErrorCount printString;
                 nextPutAll: (self unexpectedErrorCount = 1 ifTrue: [' error, '] ifFalse: [' errors, ']);
                 nextPutAll: self unexpectedPassCount printString;
                 nextPutAll: (self unexpectedPassCount = 1 ifTrue: [' unexpected pass'] ifFalse: [' unexpected passes']).!

Item was changed:
  ----- Method: TestResult>>resetFailures (in category 'initialization') -----
  resetFailures
+        "Clear the failures list ready to re-run those tests. Note that timeouts are a subset of failures."
-        "clear the failures list ready to re-run those tests"

         failures := Set new.
+        timeouts := Set new.!
-        timeouts := Set new.
-        passed removeAll: self unexpectedPasses.!

Item was added:
+ ----- Method: TestResult>>resetUnexpectedPasses (in category 'initialization') -----
+ resetUnexpectedPasses
+        "Clear the failures inside the passed list ready to re-run those tests."
+
+        passed removeAll: self unexpectedPasses.!

Squeak-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Squeak-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]