Re: TestRunner for 6.1rc2 fails 2 tests, 1 error
"Marcel Taeumel (H) via Squeak-dev" <[email protected]> Tue, 4 Aug 2026 15:19:04 +0200
| Newsgroups | gmane.comp.lang.smalltalk.squeak.general |
|---|---|
| Message-ID | <[email protected]> |
--===============3399356007914885260== Content-Type: multipart/alternative; boundary="------------e7ylKWmzWp4Ucd09hncqgH0L" --------------e7ylKWmzWp4Ucd09hncqgH0L Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi all -- I slightly adjusted the test to accept "prototypes" such as "CompiledMethodtoReturnSelf". I hope this does not render the test #testAllMethodsHaveMethodClass void. Best Marcel Am 04.08.2026 um 04:48 schrieb tim Rowledge: > >> On Aug 3, 2026, at 5:02 PM, Thiede, Christoph via Squeak-dev<[email protected]> wrote: >> >>> Second is MethodPropertiesTest>>#testAllMethodsHaveMethodClass which fails with a complaint about (nil>>nil "a CompiledMethod(3431649)”) which is apparently a quick return self. >> Ouch! This is the method of SpaceTally's Mirror context you reported in your other message ... Not sure how to fix this. In the long term, maybe we need to extract the mirror protocol from Context. In the short term, change SpaceTally class>>#initialize to Mirror := thisContext? A terminated context will not reference anything else than the method and the receiver, so this would not introduce any memory leak. > Yup, plain old thisContext appears to work for both the test and a SpaceTally. > > > Small thing spotted whilst wondering if I remembered a generic do-this-primitve method - there is no implementation of #doPrimitive: but there are two senders. Both seem to expect a plugin class to implement it. > > > tim > -- > tim Rowledge;[email protected];http://www.rowledge.org/tim > Useful random insult:- His future is behind schedule. > > > Squeak-dev mailing list [email protected] > To unsubscribe send an email [email protected] --------------e7ylKWmzWp4Ucd09hncqgH0L Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <p>Hi all --</p> <p>I slightly adjusted the test to accept "prototypes" such as "<font color="#000000">CompiledMethod</font><font color="#000000"> </font><font color="#000080">toReturnSelf". </font>I hope this does not render the test #testAllMethodsHaveMethodClass void.</p> <p>Best<br> Marcel</p> <div class="moz-cite-prefix">Am 04.08.2026 um 04:48 schrieb tim Rowledge:<br> </div> <blockquote type="cite" cite="mid:[email protected]"> <pre wrap="" class="moz-quote-pre"> </pre> <blockquote type="cite"> <pre wrap="" class="moz-quote-pre">On Aug 3, 2026, at 5:02 PM, Thiede, Christoph via Squeak-dev <a class="moz-txt-link-rfc2396E" href="mailto:[email protected]"><[email protected]></a> wrote: </pre> <blockquote type="cite"> <pre wrap="" class="moz-quote-pre">Second is MethodPropertiesTest>>#testAllMethodsHaveMethodClass which fails with a complaint about (nil>>nil "a CompiledMethod(3431649)”) which is apparently a quick return self. </pre> </blockquote> <pre wrap="" class="moz-quote-pre"> Ouch! This is the method of SpaceTally's Mirror context you reported in your other message ... Not sure how to fix this. In the long term, maybe we need to extract the mirror protocol from Context. In the short term, change SpaceTally class>>#initialize to Mirror := thisContext? A terminated context will not reference anything else than the method and the receiver, so this would not introduce any memory leak. </pre> </blockquote> <pre wrap="" class="moz-quote-pre"> Yup, plain old thisContext appears to work for both the test and a SpaceTally. Small thing spotted whilst wondering if I remembered a generic do-this-primitve method - there is no implementation of #doPrimitive: but there are two senders. Both seem to expect a plugin class to implement it. tim -- tim Rowledge; <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a>; <a class="moz-txt-link-freetext" href="http://www.rowledge.org/tim">http://www.rowledge.org/tim</a> Useful random insult:- His future is behind schedule. Squeak-dev mailing list -- <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> To unsubscribe send an email to <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a></pre> </blockquote> </body> </html> --------------e7ylKWmzWp4Ucd09hncqgH0L-- --===============3399356007914885260== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Squeak-dev mailing list -- [email protected] To unsubscribe send an email to [email protected] --===============3399356007914885260==--