Re: [squeak-smalltalk/squeak-object-memory] Bad example in Terse Guide (fractionPart) (Issue #130)

--===============3360281623159648551==
Content-Type: multipart/alternative;
 boundary="--==_mimepart_6a72697a1ec55_11d1180130121";
 charset=UTF-8
Content-Transfer-Encoding: 7bit


----==_mimepart_6a72697a1ec55_11d1180130121
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

timrowledge left a comment (squeak-smalltalk/squeak-object-memory#130)

(Cc:d to main list after the original somehow got mixed up in object-memo=
ry?)

> On Aug 4, 2026, at 1:13=E2=80=AFPM, squeak-smalltalk-bot ***@***.***> w=
rote:
> Did an update of my rc2 image and during the processing of System-mt.15=
30 the conflict browser opened - not surprising since I had made changes =
relating to the SpaceTally bug.
> Selecting the first item - SpaceTally class>#initialize & =E2=80=98acce=
pt=E2=80=99ing it was no problem.
> =

> Selecting =E2=80=98all newer=E2=80=99 raised a dNU: because MCConflict>=
>#isLocalNewer claims the =E2=80=99self localDefinition=E2=80=99 returns =
nil. Since the operation involved is an MCAddition, and they always retur=
n nil to #baseDefinition, this seems like a problem

> =

>  I=E2=80=99m reasonably sure the test for isLocal/RemoteNewer really ou=
ght to be delegated to the actual operation. Currently it is written unpl=
easantly like Python code.

Suggestion for smallest practical fix - =



MCConflict>>#chooseNewer & #chooseOlder look a bit weird. Is it actually =
possible for a method to be neither older nor newer? =

MCConflict>>#chooseSameAST is very Python-ugly; just delegate to the damn=
 operation!

tim
--
tim Rowledge; ***@***.***; http://www.rowledge.org/tim
Useful random insult:- Calls people to ask them their phone number.




-- =

Reply to this email directly or view it on GitHub:
https://github.com/squeak-smalltalk/squeak-object-memory/issues/130#issue=
comment-5185378914
You are receiving this because you commented.

Message ID: <squeak-smalltalk/squeak-object-memory/issues/130/5185378914@=
github.com>=

----==_mimepart_6a72697a1ec55_11d1180130121
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div style=3D"display: flex; flex-wrap: wrap; white-space: pre-wrap; alig=
n-items: center; "><img height=3D"20" width=3D"20" style=3D"border-radius=
:50%; margin-right: 4px;" decoding=3D"async" src=3D"https://avatars.githu=
busercontent.com/u/7818030?s=3D20&amp;v=3D4" /><strong>timrowledge</stron=
g> left a comment <a href=3D"https://github.com/squeak-smalltalk/squeak-o=
bject-memory/issues/130#issuecomment-5185378914">(squeak-smalltalk/squeak=
-object-memory#130)</a></div>
(Cc:d to main list after the original somehow got mixed up in object-memo=
ry?)
<br>

<br>
&gt; On Aug 4, 2026, at 1:13=E2=80=AFPM, squeak-smalltalk-bot ***@***.***=
&gt; wrote:
<br>
&gt; Did an update of my rc2 image and during the processing of System-mt=
.1530 the conflict browser opened - not surprising since I had made chang=
es relating to the SpaceTally bug.
<br>
&gt; Selecting the first item - SpaceTally class&gt;#initialize &amp; =E2=
=80=98accept=E2=80=99ing it was no problem.
<br>
&gt; =

<br>
&gt; Selecting =E2=80=98all newer=E2=80=99 raised a dNU: because MCConfli=
ct&gt;&gt;#isLocalNewer claims the =E2=80=99self localDefinition=E2=80=99=
 returns nil. Since the operation involved is an MCAddition, and they alw=
ays return nil to #baseDefinition, this seems like a problem
<br>

<br>
&gt; =

<br>
&gt;  I=E2=80=99m reasonably sure the test for isLocal/RemoteNewer really=
 ought to be delegated to the actual operation. Currently it is written u=
npleasantly like Python code.
<br>

<br>
Suggestion for smallest practical fix - =

<br>
<br>
<br>
MCConflict&gt;&gt;#chooseNewer &amp; #chooseOlder look a bit weird. Is it=
 actually possible for a method to be neither older nor newer? <br>
MCConflict&gt;&gt;#chooseSameAST is very Python-ugly; just delegate to th=
e damn operation!<br>
<br>
tim<br>
--<br>
tim Rowledge; ***@***.***; http://www.rowledge.org/tim<br>
Useful random insult:- Calls people to ask them their phone number.<br>
<br>
<br>


<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />Reply to this email directly, <a href=3D"https://github.com/sq=
ueak-smalltalk/squeak-object-memory/issues/130?email_source=3Dnotificatio=
ns&amp;email_token=3DBFYAK6NQO3OXYKJQLO2GHDD5IJQPVA5CNFSNUABFM5UWIORPF5TW=
S5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYGUZTOOBZGE2KM4TFMFZW63VHMNXW23LFNZ2KK=
ZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5185378914">view it on GitHub<=
/a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/BFYA=
K6LYVMP356XBAG3S3WL5IJQPVAVCNFSNUABFKJSXA33TNF2G64TZHM2DKNBYHA3TANRUHNEXG=
43VMU5TEOJXG44TSNBQGYY2C5QC">unsubscribe</a>.<br />Triage notifications, =
keep track of coding agent tasks and review pull requests on the go with =
GitHub Mobile for <a href=3D"https://github.com/notifications/mobile/ios/=
BFYAK6OZ55QLWW43LOQQUA35IJQPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN=
5WW2ZLOOQXTKMJYGUZTOOBZGE2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5=
UW64Y">iOS</a> and <a href=3D"https://github.com/notifications/mobile/and=
roid/BFYAK6INHEVZRFA6NXIFTPT5IJQPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZX=
KZKDN5WW2ZLOOQXTKMJYGUZTOOBZGE2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXI=
ZLSL5QW4ZDSN5UWI">Android</a>. Download it today!
<br />You are receiving this because you commented.<img src=3D"https://gi=
thub.com/notifications/beacon/BFYAK6JRY4T4YLHZLQT2CRD5IJQPVBFCNFSM6AAAAAC=
43LFXAKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTYAAAAA=
CNISTJRKM4TFMFZW63VHMNXW23LFNZ2A.gif" height=3D"1" width=3D"1" alt=3D"" /=
><span style=3D"color: transparent; font-size: 0; display: none; visibili=
ty: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width:=
 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;squeak-smalltalk/=
squeak-object-memory/issues/130/5185378914</span><span>@</span><span>gith=
ub</span><span>.</span><span>com&gt;</span></span></p>

<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/squeak-smalltalk/squeak-object-memory/issue=
s/130?email_source=3Dnotifications\u0026email_token=3DBFYAK6PUEPLULNJLPMR=
WQWD5IJQPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYGUZT=
OOBZGE2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJK3HNVQWS3C7MNWGSY3L#issuecomment=
-5185378914",
"url": "https://github.com/squeak-smalltalk/squeak-object-memory/issues/1=
30?email_source=3Dnotifications\u0026email_token=3DBFYAK6PUEPLULNJLPMRWQW=
D5IJQPVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYGUZTOOB=
ZGE2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJK3HNVQWS3C7MNWGSY3L#issuecomment-51=
85378914",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>

----==_mimepart_6a72697a1ec55_11d1180130121--

--===============3360281623159648551==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Squeak-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
--===============3360281623159648551==--