Re: Found Bug But Not Sure How to Proceed To Fix
Bob Arning <[email protected]> Fri, 2 Mar 2018 15:19:54 -0500
| Newsgroups | gmane.comp.lang.smalltalk.squeak.squeakland |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============3024372697282443633== Content-Type: multipart/alternative; boundary="------------1BF4B390F5D58946FD4AF2E9" Content-Language: en-US This is a multi-part message in MIME format. --------------1BF4B390F5D58946FD4AF2E9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit TransformationMorph>>computeBounds self hasSubmorphs ifTrue: [bounds _ (transform localBoundsToGlobal: (Rectangle merging: (self submorphs collect: [:m | m fullBounds]))) truncated expandBy: 1]. fullBounds _ bounds. Note the expandBy: 1 On 3/2/18 1:59 PM, Jeremy Landry wrote: > Actually to add a little more insight if possible, you can create bug > with the following actions: > > make a new playfield > make 2 new rectangles and place them into the playfield. > Rotate one of them 90 degrees. > Turn gridding on in the playfield. > > The rotated and unscaled rectangle will not align with the non-rotated > one with gridding. Something about making a bitmap copy is offsetting > the values, my guess is there's a rounding problem that is popping up > on these objects, thus scale and rotation get offset for some reason, > and specifically changes the origin by 1@-1 somewhere...it causes > graphical glitches leaving 'garbage' with playfield indicators when > the object that has the indicator is moved and also shows up with > rotated ellipses. What is the common thread through them all? What > method are they all accessing? > > On Fri, Mar 2, 2018 at 10:45 AM, Jeremy Landry <[email protected] > <mailto:[email protected]>> wrote: > > You will also notice if you rotate any shape, it becomes a bit > map. Scale it and you will see that problem re-occur even with > built-in objects. Could it be the masking offset, too? that > causes this? I'm still investigating, but I'm not sure how to > step through 'already working' things specifically related to what > I'm trying to look at. > > On Fri, Mar 2, 2018 at 10:42 AM, Jeremy Landry <[email protected] > <mailto:[email protected]>> wrote: > > Hi, it only appears when scaling a morph. Here is > example...it is my belief (how does one step through code with > debugger if there's no bug happening?); > > Whatever code is common that scales morphs is being offset > incorrectly. The first image shows the 'garbage' left behind > by playfield indicator if that option is set. It seems it was > only tested in 'holders' and thus likely not picked up during > 'intended' use. > > Next, two pictures show scaling as where the misalignment > starts. This might be why you could not recreate bug; > resizing rectangle changes rectangle morph extent, whereas > scaling is a differnet piece of code and therefore different > outcome. > > Image included. This works with *anything* scaled. > https://imgur.com/a/6zEWq > > On Fri, Mar 2, 2018 at 10:20 AM, Bob Arning > <[email protected] <mailto:[email protected]>> wrote: > > I tried to recreate your example and could not. How did > you create the two morphs in your example? Are you certain > the read/gray morph does not have some transparent pixels > along the top and left? > > > On 3/2/18 12:50 PM, Jeremy Landry wrote: >> I did a little more digging, just for the record...and it >> turns out it's scaling error. No matter what, scaling >> offsets morphs by 1@-1. I'm still looking for where this >> occurs and why. So far, injecting intentionally bad >> values into bordered morph and sketch classes hasn't >> produced any change. It 'feels' like most of that code >> isn't even used, but then again, I might not have >> genuinely created a new object with that code and system >> might have been giving me what was already in system... >> >> >> On Fri, Mar 2, 2018 at 7:15 AM, Bert Freudenberg >> <[email protected] <mailto:[email protected]>> wrote: >> >> That bug tracker is pretty much dead, since all >> ongoing development moved to squeak.org >> <http://squeak.org>. >> >> The plan was to make a new Etoys release based on the >> latest Squeak source base, but we have not have >> enough developer time to make that actually happen. >> >> - Bert - >> >> On 1 March 2018 at 06:03, Nicco Kunzmann (rambler) >> <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi, >> >> I found a bug tracker on the squeakland site: >> http://tracker.squeakland.org/secure/Dashboard.jspa >> <http://tracker.squeakland.org/secure/Dashboard.jspa> >> >> I think, you can describe the problem there as an >> issue and hand in the fix. >> They may also know how to guide you further if >> the code base is somewhere else. >> If you have problems there (login, no response), >> I guess, this mailing list is one place to ask >> for help. >> >> Best, >> Nicco >> >> >> On 03/01/2018 03:34 AM, Jeremy Landry wrote: >>> Hi, while working on a project needing precise >>> alignment of sketches/bitmaps and rectangles >>> using playfield 'use gridding', it seems that >>> there's a difference of detected origin. >>> >>> Here's a screenshot with magnifier showing the >>> discrepency. >>> https://imgur.com/a/tcaRu >>> >>> I'm quite certain this bug is the one that >>> causes bad redrawing, especially when showing a >>> cursor move when 'indicate cursor' is activated >>> in a playfield. >>> >>> If I correct this bug inside of a project, will >>> it load into an image where it has not been >>> fixed and be fixed? >>> >>> I haven't actually fixed the bug yet, but didn't >>> want to waste time on it if the fix will not >>> travel with the project. >>> >>> Thanks in advance for any input. >>> >>> >>> _______________________________________________ >>> squeakland mailing list >>> squeakland-bD51WKytQuId/fn+uklp/[email protected] >>> <mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]> >>> http://lists.squeakland.org/mailman/listinfo/squeakland >>> <http://lists.squeakland.org/mailman/listinfo/squeakland> >> >> >> _______________________________________________ >> squeakland mailing list >> squeakland-bD51WKytQuId/fn+uklp/[email protected] >> <mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]> >> http://lists.squeakland.org/mailman/listinfo/squeakland >> <http://lists.squeakland.org/mailman/listinfo/squeakland> >> >> >> >> _______________________________________________ >> squeakland mailing list >> squeakland-bD51WKytQuId/fn+uklp/[email protected] >> <mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]> >> http://lists.squeakland.org/mailman/listinfo/squeakland >> <http://lists.squeakland.org/mailman/listinfo/squeakland> >> >> >> >> >> _______________________________________________ >> squeakland mailing list >> squeakland-bD51WKytQuId/fn+uklp/[email protected] >> <mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]> >> http://lists.squeakland.org/mailman/listinfo/squeakland >> <http://lists.squeakland.org/mailman/listinfo/squeakland> > > > _______________________________________________ > squeakland mailing list > squeakland-bD51WKytQuId/fn+uklp/[email protected] > <mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]> > http://lists.squeakland.org/mailman/listinfo/squeakland > <http://lists.squeakland.org/mailman/listinfo/squeakland> > > > > --------------1BF4B390F5D58946FD4AF2E9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <p><font face="Georgia">TransformationMorph>>computeBounds<br> self hasSubmorphs ifTrue:<br> [bounds _ (transform localBoundsToGlobal:<br> (Rectangle merging:<br> (self submorphs collect: [:m | m fullBounds]))) truncated<br> expandBy: 1].<br> fullBounds _ bounds.</font></p> <p><font face="Georgia">Note the expandBy: 1</font><br> </p> <br> <div class="moz-cite-prefix">On 3/2/18 1:59 PM, Jeremy Landry wrote:<br> </div> <blockquote type="cite" cite="mid:CAMYa41k1xWoMV6hmLYGHdySz2knjaGQL=qQ0=NZH4tkPt2htmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org"> <div dir="ltr">Actually to add a little more insight if possible, you can create bug with the following actions: <div><br> </div> <div>make a new playfield</div> <div>make 2 new rectangles and place them into the playfield.</div> <div>Rotate one of them 90 degrees.</div> <div>Turn gridding on in the playfield.</div> <div><br> </div> <div>The rotated and unscaled rectangle will not align with the non-rotated one with gridding. Something about making a bitmap copy is offsetting the values, my guess is there's a rounding problem that is popping up on these objects, thus scale and rotation get offset for some reason, and specifically changes the origin by 1@-1 somewhere...it causes graphical glitches leaving 'garbage' with playfield indicators when the object that has the indicator is moved and also shows up with rotated ellipses. What is the common thread through them all? What method are they all accessing?</div> </div> <div class="gmail_extra"><br> <div class="gmail_quote">On Fri, Mar 2, 2018 at 10:45 AM, Jeremy Landry <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr">You will also notice if you rotate any shape, it becomes a bit map. Scale it and you will see that problem re-occur even with built-in objects. Could it be the masking offset, too? that causes this? I'm still investigating, but I'm not sure how to step through 'already working' things specifically related to what I'm trying to look at.</div> <div class="HOEnZb"> <div class="h5"> <div class="gmail_extra"><br> <div class="gmail_quote">On Fri, Mar 2, 2018 at 10:42 AM, Jeremy Landry <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr">Hi, it only appears when scaling a morph. Here is example...it is my belief (how does one step through code with debugger if there's no bug happening?); <div><br> </div> <div>Whatever code is common that scales morphs is being offset incorrectly. The first image shows the 'garbage' left behind by playfield indicator if that option is set. It seems it was only tested in 'holders' and thus likely not picked up during 'intended' use. </div> <div><br> </div> <div>Next, two pictures show scaling as where the misalignment starts. This might be why you could not recreate bug; resizing rectangle changes rectangle morph extent, whereas scaling is a differnet piece of code and therefore different outcome.</div> <div><br> </div> <div>Image included. This works with *anything* scaled. </div> <div><a href="https://imgur.com/a/6zEWq" target="_blank" moz-do-not-send="true">https://imgur.com/a/6zEWq</a><br> </div> </div> <div class="m_3011170771951225968HOEnZb"> <div class="m_3011170771951225968h5"> <div class="gmail_extra"><br> <div class="gmail_quote">On Fri, Mar 2, 2018 at 10:20 AM, Bob Arning <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF"> <p><font face="Georgia">I tried to recreate your example and could not. How did you create the two morphs in your example? Are you certain the read/gray morph does not have some transparent pixels along the top and left?</font><br> </p> <div> <div class="m_3011170771951225968m_3198776054015858061h5"> <br> <div class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389moz-cite-prefix">On 3/2/18 12:50 PM, Jeremy Landry wrote:<br> </div> <blockquote type="cite"> <div dir="ltr">I did a little more digging, just for the record...and it turns out it's scaling error. No matter what, scaling offsets morphs by 1@-1. I'm still looking for where this occurs and why. So far, injecting intentionally bad values into bordered morph and sketch classes hasn't produced any change. It 'feels' like most of that code isn't even used, but then again, I might not have genuinely created a new object with that code and system might have been giving me what was already in system... <div><br> </div> </div> <div class="gmail_extra"><br> <div class="gmail_quote">On Fri, Mar 2, 2018 at 7:15 AM, Bert Freudenberg <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000">That bug tracker is pretty much dead, since all ongoing development moved to <a href="http://squeak.org" target="_blank" moz-do-not-send="true">squeak.org</a>.</div> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><br> </div> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000">The plan was to make a new Etoys release based on the latest Squeak source base, but we have not have enough developer time to make that actually happen.</div> <span class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389HOEnZb"><font color="#888888"> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><br> </div> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000">- Bert -</div> </font></span> <div> <div class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389h5"> <div class="gmail_extra"><br> <div class="gmail_quote">On 1 March 2018 at 06:03, Nicco Kunzmann (rambler) <span dir="ltr"><<a href="mailto:[email protected]" target="_blank" moz-do-not-send="true">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF"> Hi,<br> <br> I found a bug tracker on the squeakland site:<br> <a href="http://tracker.squeakland.org/secure/Dashboard.jspa" target="_blank" moz-do-not-send="true">http://tracker.squeakland.org/<wbr>secure/Dashboard.jspa</a><br> <br> I think, you can describe the problem there as an issue and hand in the fix.<br> They may also know how to guide you further if the code base is somewhere else.<br> If you have problems there (login, no response), I guess, this mailing list is one place to ask for help.<br> <br> Best,<br> Nicco <div> <div class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637h5"><br> <br> <div class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637m_-1252469366745025355moz-cite-prefix">On 03/01/2018 03:34 AM, Jeremy Landry wrote:<br> </div> </div> </div> <blockquote type="cite"> <div> <div class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637h5"> <div dir="ltr">Hi, while working on a project needing precise alignment of sketches/bitmaps and rectangles using playfield 'use gridding', it seems that there's a difference of detected origin. <div><br> </div> <div>Here's a screenshot with magnifier showing the discrepency. </div> <div> <span><a href="https://imgur.com/a/tcaRu" target="_blank" moz-do-not-send="true">https://imgur.com/a/tcaRu</a></span> <br> </div> <div><br> </div> <div>I'm quite certain this bug is the one that causes bad redrawing, especially when showing a cursor move when 'indicate cursor' is activated in a playfield.</div> <div><br> </div> <div>If I correct this bug inside of a project, will it load into an image where it has not been fixed and be fixed?</div> <div><br> </div> <div>I haven't actually fixed the bug yet, but didn't want to waste time on it if the fix will not travel with the project. </div> <div><br> </div> <div>Thanks in advance for any input.</div> </div> <br> <fieldset class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637m_-1252469366745025355mimeAttachmentHeader"></fieldset> <br> </div> </div> <pre>______________________________<wbr>_________________ squeakland mailing list <a class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637m_-1252469366745025355moz-txt-link-abbreviated" href="mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]" target="_blank" moz-do-not-send="true">squeakland-bD51WKytQuId/fn+uklp/[email protected]<wbr>g</a> <a class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389m_-6539519090481828637m_-1252469366745025355moz-txt-link-freetext" href="http://lists.squeakland.org/mailman/listinfo/squeakland" target="_blank" moz-do-not-send="true">http://lists.squeakland.org/ma<wbr>ilman/listinfo/squeakland</a> </pre> </blockquote> <br> </div> <br> ______________________________<wbr>_________________<br> squeakland mailing list<br> <a href="mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]" target="_blank" moz-do-not-send="true">squeakland-bD51WKytQuId/fn+uklp/[email protected]<wbr>g</a><br> <a href="http://lists.squeakland.org/mailman/listinfo/squeakland" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.squeakland.org/ma<wbr>ilman/listinfo/squeakland</a><br> <br> </blockquote> </div> <br> </div> </div> </div> </div> <br> ______________________________<wbr>_________________<br> squeakland mailing list<br> <a href="mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]" target="_blank" moz-do-not-send="true">squeakland-bD51WKytQuId/fn+uklp/[email protected]<wbr>g</a><br> <a href="http://lists.squeakland.org/mailman/listinfo/squeakland" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.squeakland.org/ma<wbr>ilman/listinfo/squeakland</a><br> <br> </blockquote> </div> <br> </div> <br> <fieldset class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389mimeAttachmentHeader"></fieldset> <br> <pre>______________________________<wbr>_________________ squeakland mailing list <a class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389moz-txt-link-abbreviated" href="mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]" target="_blank" moz-do-not-send="true">squeakland-bD51WKytQuId/fn+uklp/[email protected]<wbr>g</a> <a class="m_3011170771951225968m_3198776054015858061m_-5490095820042152389moz-txt-link-freetext" href="http://lists.squeakland.org/mailman/listinfo/squeakland" target="_blank" moz-do-not-send="true">http://lists.squeakland.org/ma<wbr>ilman/listinfo/squeakland</a> </pre> </blockquote> <br> </div> </div> </div> <br> ______________________________<wbr>_________________<br> squeakland mailing list<br> <a href="mailto:squeakland-bD51WKytQuId/fn+uklp/[email protected]" target="_blank" moz-do-not-send="true">squeakland-bD51WKytQuId/fn+uklp/[email protected]<wbr>g</a><br> <a href="http://lists.squeakland.org/mailman/listinfo/squeakland" rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.squeakland.org/ma<wbr>ilman/listinfo/squeakland</a><br> <br> </blockquote> </div> <br> </div> </div> </div> </blockquote> </div> <br> </div> </div> </div> </blockquote> </div> <br> </div> </blockquote> <br> </body> </html> --------------1BF4B390F5D58946FD4AF2E9-- --===============3024372697282443633== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kc3F1ZWFrbGFu ZCBtYWlsaW5nIGxpc3QKc3F1ZWFrbGFuZEBsaXN0cy5zcXVlYWtsYW5kLm9yZwpodHRwOi8vbGlz dHMuc3F1ZWFrbGFuZC5vcmcvbWFpbG1hbi9saXN0aW5mby9zcXVlYWtsYW5kCg== --===============3024372697282443633==--