Re: Found Bug But Not Sure How to Proceed To Fix

--===============0608785015759212606==
Content-Type: multipart/alternative; boundary="001a1144869cd2990a0566817767"

--001a1144869cd2990a0566817767
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 3 March 2018 at 02:37, David T. Lewis <[email protected]> wrote:

> Does anything bad happen if the "expandBy: 1" is removed? I tried removin=
g
> it
> in my Squeak trunk image, and "CompassDialMorph new openInWorld" (which i=
s
> one
> user of TransformationMorph) seems to work nicely.
>

=E2=80=8BI bet it's there to avoid gribblies left behind when dragging.=E2=
=80=8B The damage
rectangle needs to be large enough to cover every pixel touched even in
rotated versions.

=E2=80=8BMaybe the =E2=80=8B
=E2=80=8B"=E2=80=8B
truncated=E2=80=8B expandBy: 1
=E2=80=8B"=E2=80=8B should be something like "rounded outwards"?

But generally speaking, as long as we have the warpblt hack + integer
coords instead of a proper hierarchical transform framework we will run
into these rounding issues again and again.


=E2=80=8B- Bert -=E2=80=8B

--001a1144869cd2990a0566817767
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he=
lvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><span style=3D"font-fa=
mily:arial,sans-serif;color:rgb(34,34,34)">On 3 March 2018 at 02:37, David =
T. Lewis </span><span dir=3D"ltr" style=3D"font-family:arial,sans-serif;col=
or:rgb(34,34,34)">&lt;<a href=3D"mailto:[email protected]" target=3D"_bla=
nk">[email protected]</a>&gt;</span><span style=3D"font-family:arial,sans=
-serif;color:rgb(34,34,34)"> wrote:</span><br></div><div class=3D"gmail_ext=
ra"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">Does anything bad happen if the &quot;expandBy: 1&quot; is removed? I=
 tried removing it<br>
in my Squeak trunk image, and &quot;CompassDialMorph new openInWorld&quot; =
(which is one<br>
user of TransformationMorph) seems to work nicely.<br></blockquote><div><br=
></div><div><div class=3D"gmail_default" style=3D"font-family:arial,helveti=
ca,sans-serif;font-size:small;color:rgb(0,0,0)">=E2=80=8BI bet it&#39;s the=
re to avoid gribblies left behind when dragging.=E2=80=8B The damage rectan=
gle needs to be large enough to cover every pixel touched even in rotated v=
ersions.</div></div><br></div><div class=3D"gmail_quote"><div class=3D"gmai=
l_quote"><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,=
sans-serif;font-size:small;color:rgb(0,0,0);display:inline">=E2=80=8BMaybe =
the =E2=80=8B</div><div class=3D"gmail_default" style=3D"font-family:arial,=
helvetica,sans-serif;font-size:small;color:rgb(0,0,0);display:inline">=E2=
=80=8B&quot;=E2=80=8B</div>truncated=E2=80=8B expandBy: 1<div class=3D"gmai=
l_default" style=3D"font-family:arial,helvetica,sans-serif;font-size:small;=
color:rgb(0,0,0);display:inline">=E2=80=8B&quot;=E2=80=8B should be somethi=
ng like &quot;rounded outwards&quot;?</div></div><div class=3D"gmail_quote"=
><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-ser=
if;font-size:small;color:rgb(0,0,0);display:inline"><br></div></div><div cl=
ass=3D"gmail_quote"><div class=3D"gmail_default" style=3D"font-family:arial=
,helvetica,sans-serif;font-size:small;color:rgb(0,0,0);display:inline">But =
generally speaking, as long as we have the=C2=A0warpblt hack + integer coor=
ds instead of a proper hierarchical transform framework we will run into th=
ese rounding issues again and again.</div><br></div><div class=3D"gmail_quo=
te"><br></div></div><div class=3D"gmail_quote"><div class=3D"gmail_default"=
 style=3D"font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(=
0,0,0)">=E2=80=8B- Bert -=E2=80=8B</div><br></div></div></div>

--001a1144869cd2990a0566817767--

--===============0608785015759212606==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Kc3F1ZWFrbGFu
ZCBtYWlsaW5nIGxpc3QKc3F1ZWFrbGFuZEBsaXN0cy5zcXVlYWtsYW5kLm9yZwpodHRwOi8vbGlz
dHMuc3F1ZWFrbGFuZC5vcmcvbWFpbG1hbi9saXN0aW5mby9zcXVlYWtsYW5kCg==

--===============0608785015759212606==--