svn commit: r13774 - trunk/src_new/org/argouml: ui/explorer uml/reveng/ui

Author: tfmorris
Date: 2007-11-15 14:16:52-0800
New Revision: 13774

Modified:
   trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java
   trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java

Log:
Add TODOs for reducing coupling.

Modified: trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java?view=diff&rev=13774&p1=trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java&p2=trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java&r1=13773&r2=13774
==============================================================================
--- trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java	(original)
+++ trunk/src_new/org/argouml/ui/explorer/ExplorerEventAdaptor.java	2007-11-15 14:16:52-0800
@@ -90,6 +90,9 @@
     /**
      * The tree structure has changed significantly.  
      * Inform the associated tree model.
+     * 
+     * TODO:  This shouldn't be public.  Components desiring to
+     * inform the Explorer of changes should send events.
      */
     public void structureChanged() {
         if (treeModel == null) {
@@ -102,7 +105,11 @@
      * forwards this event to the tree model.
      *
      * @param element the modelelement to be removed
+     * @deprecated for 0.25.4 by tfmorris.  Send an event rather than calling
+     * this method directly.  This is not currently used by ArgoUML and removal
+     * is handled by Model subsystem events.
      */
+    @Deprecated
     public void modelElementRemoved(Object element) {
         if (treeModel == null) {
             return;
@@ -114,6 +121,9 @@
      * forwards this event to the tree model.
      *
      * @param element the modelelement to be added
+     * 
+     * TODO:  This shouldn't be public.  Components desiring to
+     * inform the Explorer of changes should send events.
      */
     public void modelElementAdded(Object element) {
         if (treeModel == null) {
@@ -126,6 +136,9 @@
      * forwards this event to the tree model.
      *
      * @param element the modelelement to be changed
+     * 
+     * TODO:  This shouldn't be public.  Components desiring to
+     * inform the Explorer of changes should send events.
      */
     public void modelElementChanged(Object element) {
         if (treeModel == null) {

Modified: trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java?view=diff&rev=13774&p1=trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java&p2=trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java&r1=13773&r2=13774
==============================================================================
--- trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java	(original)
+++ trunk/src_new/org/argouml/uml/reveng/ui/RESequenceDiagramDialog.java	2007-11-15 14:16:52-0800
@@ -528,6 +528,7 @@
 
             diagram.add(crFig);
             graphModel.addNode(node);
+            // TODO: Send event instead of calling event adapter directly
             ExplorerEventAdaptor.getInstance().modelElementChanged(
                 Model.getFacade().getNamespace(classifier));
         }