svn commit: r14322 - trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java

[email protected]
Newsgroups gmane.comp.lang.uml.argouml.cvs
Message-ID <[email protected]>
Author: penyaskito
Date: 2008-04-11 06:30:17-0700
New Revision: 14322

Modified:
   trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java

Log:
Refactoring of the arrow style logic.

Modified: trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java?view=diff&rev=14322&p1=trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java&p2=trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java&r1=14321&r2=14322
==============================================================================
--- trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java	(original)
+++ trunk/src/argouml-core-diagrams-sequence2/src/org/argouml/uml/diagram/sequence2/ui/FigMessage.java	2008-04-11 06:30:17-0700
@@ -78,30 +78,33 @@
     @Override
     public void setOwner(Object owner) {       
         super.setOwner(owner);
-        Object action = getAction();
-        if (Model.getFacade().isAReturnAction(action)) {
-            arrowHead = new ArrowHeadGreater();
-            getFig().setDashed(true);
-        }
-        else if (Model.getFacade().isADestroyAction(action)) {
-            arrowHead = new ArrowHeadGreater();
-            getFig().setDashed(true);
-        }
-        else if (Model.getFacade().isACreateAction(action)) {
-            arrowHead = new ArrowHeadTriangle();
-            // dashed it's false by default.
-        }
-        else if (Model.getFacade().isACallAction(action)) {
-            arrowHead = new ArrowHeadTriangle();
-            // dashed it's false by default.
-        }
-        else {     
-            String message = "The owner must be a message with an "
-                + "action - got a " + owner.getClass().getName();
-            LOG.error(message);
-            throw new IllegalArgumentException(message);
-        }
-        setDestArrowHead(arrowHead);
+        updateArrow();
+    }
+
+    /**
+     * Updates the arrow head and the arrow line according
+     * to the action type..
+     */
+    private void updateArrow() {
+	Object action = getAction();
+	if (Model.getFacade().isAReturnAction(action)) {
+	    arrowHead = new ArrowHeadGreater();
+	    getFig().setDashed(true);
+	}
+	else if (Model.getFacade().isADestroyAction(action)) {
+	    arrowHead = new ArrowHeadGreater();
+	    getFig().setDashed(true);
+	}
+	else if (Model.getFacade().isACreateAction(action)) {
+	    arrowHead = new ArrowHeadTriangle();
+	    // dashed it's false by default.
+	}
+	else if (Model.getFacade().isACallAction(action)) {
+	    arrowHead = new ArrowHeadTriangle();
+	    // dashed it's false by default.
+	}
+
+	setDestArrowHead(arrowHead);
     }
 
     /**
@@ -135,14 +138,7 @@
      */
     public void setFig(Fig f) {        
         super.setFig(f);
-        Object action = getAction();
-        if (Model.getFacade().isAReturnAction(action)) {
-            getFig().setDashed(true);
-        }
-        else if (Model.getFacade().isADestroyAction(action)) {
-            getFig().setDashed(true);
-        }
-        // in other cases there isn't a dashed line, default is false.
+        updateArrow();
     }
     
     int getFinalY() {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.