svn commit: r14340 - trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java

Author: tfmorris
Date: 2008-04-14 12:04:58-0700
New Revision: 14340

Modified:
   trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java

Log:
Issue 4988: Make sure our metaclasses list can't be modified by someone else

Modified: trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java?view=diff&rev=14340&p1=trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java&p2=trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java&r1=14339&r2=14340
==============================================================================
--- trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java	(original)
+++ trunk/src/app/src/org/argouml/uml/ui/foundation/extension_mechanisms/PropPanelStereotype.java	2008-04-14 12:04:58-0700
@@ -258,8 +258,8 @@
     class ActionAddStereotypeBaseClass extends AbstractActionAddModelElement2 {
 
         @Override
-        protected List getChoices() {
-            return metaClasses;
+        protected List<String> getChoices() {
+            return Collections.unmodifiableList(metaClasses);
         }
 
         @Override
@@ -268,10 +268,10 @@
         }
 
         @Override
-        protected List getSelected() {
-            List result = new ArrayList();
+        protected List<String> getSelected() {
+            List<String> result = new ArrayList<String>();
             if (Model.getFacade().isAStereotype(getTarget())) {
-                Collection bases = 
+                Collection<String> bases = 
                     Model.getFacade().getBaseClasses(getTarget());
                 result.addAll(bases);
             }