svn commit: r14583 - trunk/src/argouml-app/src/org/argouml/uml: diagram/sequence/ui ui

[email protected]
Newsgroups gmane.comp.lang.uml.argouml.cvs
Message-ID <[email protected]>
Author: tfmorris
Date: 2008-05-01 16:50:29-0700
New Revision: 14583

Modified:
   trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java
   trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java

Log:
TODOs for issue 5058

Modified: trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java?view=diff&rev=14583&p1=trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java&p2=trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java&r1=14582&r2=14583
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/uml/diagram/sequence/ui/FigMessage.java	2008-05-01 16:50:29-0700
@@ -88,6 +88,8 @@
         // the menu item for RE a sequence into the diagram is offered always,
         // because a check (e.g. does a operation with a body exist) would be
         // too expensive
+        // TODO: There is a cyclic dependency between ActionRESequenceDiagram
+        // and FigMessage
         popUpActions.add(popUpActions.size() - getPopupAddOffset(),
                 new ActionRESequenceDiagram(this));
 
@@ -299,7 +301,8 @@
 
     /**
      * This won't work, so this implementation does nothing.
-     *
+     * 
+     * {@inheritDoc}
      * @see org.argouml.uml.diagram.ui.FigEdgeModelElement#determineFigNodes()
      */
     @Override

Modified: trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java?view=diff&rev=14583&p1=trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java&p2=trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java&r1=14582&r2=14583
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/uml/ui/ActionRESequenceDiagram.java	2008-05-01 16:50:29-0700
@@ -41,9 +41,6 @@
  */
 public class ActionRESequenceDiagram extends AbstractAction {
 
-    ////////////////////////////////////////////////////////////////
-    // constructors
-
     /**
      * The constructor. If a figure is given, then it is invoked inside of a
      * sequence diagram, so it will work with this diagram. If figure is null,
@@ -63,9 +60,6 @@
         this(null);
     }
 
-    ////////////////////////////////////////////////////////////////
-    // main methods
-
     /*
      * @see java.awt.event.ActionListener#actionPerformed(java.awt.event.ActionEvent)
      */
@@ -84,6 +78,8 @@
                 // it is highly desirable that the message action
                 // already knows it's operation
                 RESequenceDiagramDialog dialog =
+                    // TODO: There is a cyclic dependency between 
+                    // ActionRESequenceDiagram and FigMessage
                     new RESequenceDiagramDialog(op, (FigMessage) messageFig);
                 dialog.setVisible(true);
             } else {
@@ -115,6 +111,8 @@
                     while (iter != null && iter.hasNext()) {
                         op = iter.next();
                         if (opName.equals(Model.getFacade().getName(op))) {
+                            // TODO: There is a cyclic dependency between 
+                            // ActionRESequenceDiagram and FigMessage
                             RESequenceDiagramDialog dialog =
                                 new RESequenceDiagramDialog(op,
                                         (FigMessage) messageFig);
@@ -124,15 +122,13 @@
                     }
                 }
             }
-            // Model.getCoreHelper().setName(
-            //     ((FigEdgeModelElement) messageFig).getOwner(),
-            //     "Hello World");
         }
     }
 
     /*
      * @see javax.swing.Action#isEnabled()
      */
+    @Override
     public boolean isEnabled() {
         Object target = TargetManager.getInstance().getModelTarget();
         return Model.getFacade().isAOperation(target)
@@ -145,4 +141,4 @@
      * The UID.
      */
     private static final long serialVersionUID = 2915509413708666273L;
-} /* end class ActionRESequenceDiagram */
+}
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.