svn commit: r14754 - trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java

Author: tfmorris
Date: 2008-05-16 09:23:24-0700
New Revision: 14754

Modified:
   trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java

Log:
Restore previous API.  Used by todo.tee

Modified: trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java?view=diff&rev=14754&p1=trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java&p2=trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java&r1=14753&r2=14754
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/persistence/ResolvedCriticXMLHelper.java	2008-05-16 09:23:24-0700
@@ -1,5 +1,5 @@
 // $Id$
-// Copyright (c) 1996-2006 The Regents of the University of California. All
+// Copyright (c) 1996-2008 The Regents of the University of California. All
 // Rights Reserved. Permission to use, copy, modify, and distribute this
 // software and its documentation without fee, and without a written
 // agreement is hereby granted, provided that the above copyright notice
@@ -24,7 +24,6 @@
 
 package org.argouml.persistence;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Vector;
 
@@ -72,42 +71,31 @@
     /**
      * Gets the offender vector of this critic where each offender is
      * wrapped in an OffenderXMLHelper.
-     *
+     * 
      * @return	A Vector of OffenderXMLHelpers, or null if there are
      *		no offenders.
      * @see	OffenderXMLHelper
-     * @deprecated for 0.25.6 by tfmorris.  Use {@link #getOffenders()}.
+     * NOTE: used by todo.tee
      */
     public Vector<OffenderXMLHelper> getOffenderList() {
-        Vector<OffenderXMLHelper> out = new Vector<OffenderXMLHelper>();
-        collectOffenders(out);
-	return out;
-    }
+	List<String> in = item.getOffenderList();
+	Vector<OffenderXMLHelper> out;
 
+	if (in == null) {
+	    return null;
+	}
+	out = new Vector<OffenderXMLHelper>();
+	for (String elem : in) {
+	    try {
+		OffenderXMLHelper helper =
+		    new OffenderXMLHelper(elem);
+		out.addElement(helper);
+	    } catch (ClassCastException cce) {
+	        // TODO: Shouldn't we do something here?
+	    }
+	}
 
-    private void collectOffenders(List<OffenderXMLHelper> out) {
-        List<String> in = item.getOffenderList();
-        if (in == null) {
-            return;
-        }
-        for (String element : in) {
-            out.add(new OffenderXMLHelper(element));
-        }
-    }
-    
-    /**
-     * Gets the offender list of this critic where each offender is wrapped in
-     * an OffenderXMLHelper.
-     * 
-     * @return A List of OffenderXMLHelpers. If there are no offenders it
-     *         returns an empty list.
-     * @see OffenderXMLHelper
-     */
-    public List<OffenderXMLHelper> getOffenders() {
-        List<OffenderXMLHelper> out = new ArrayList<OffenderXMLHelper>();
-        collectOffenders(out);
-        return out;
+	return out;
     }
-
 }