svn commit: r15639 - trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java

[email protected]
Newsgroups gmane.comp.lang.uml.argouml.cvs
Message-ID <[email protected]>
Author: tfmorris
Date: 2008-08-28 20:58:41-0700
New Revision: 15639

Modified:
   trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java

Log:
Add performance TODOs.  No code changes.

Modified: trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java?view=diff&rev=15639&p1=trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java&p2=trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java&r1=15638&r2=15639
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/application/events/ArgoEventPump.java	2008-08-28 20:58:41-0700
@@ -124,14 +124,17 @@
         synchronized (listeners) {
             List<Pair> removeList = new ArrayList<Pair>();
             if (event == ArgoEventTypes.ANY_EVENT) {
+                // TODO: This is a linear search of a list that contain many
+                // thousands of items (one for every Fig in the entire project)
                 for (Pair p : listeners) {
                     if (p.listener == listener) {
                         removeList.add(p);
                     }
                 }
-
             } else {
                 Pair test = new Pair(event, listener);
+                // TODO: This is a linear search of a list that contain many
+                // thousands of items (one for every Fig in the entire project)
                 for (Pair p : listeners) {
                     if (p.equals(test)) {
                         removeList.add(p);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.