svn commit: r16146 - trunk/src/argouml-app/src/org/argouml/uml/generator

Author: tfmorris
Date: 2008-11-23 09:47:50-0800
New Revision: 16146

Modified:
   trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java
   trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java

Log:
Add warnings/TODOs to places using default platform character encoding

Modified: trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java?view=diff&rev=16146&p1=trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java&p2=trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java&r1=16145&r2=16146
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/uml/generator/AbstractSection.java	2008-11-23 09:47:50-0800
@@ -86,6 +86,8 @@
         try {
             FileReader f = new FileReader(filename);
             BufferedReader fr = new BufferedReader(f);
+            // TODO: This is using the default platform character encoding
+            // specifying an encoding will produce more predictable results
             FileWriter fw = new FileWriter(filename + ".out");
             String line = "";
             line = fr.readLine();
@@ -149,6 +151,8 @@
      */
     public void read(String filename) {
         try {
+            // TODO: This is using the default platform character encoding
+            // specifying an encoding will produce more predictable results
             FileReader f = new FileReader(filename);
             BufferedReader fr = new BufferedReader(f);
 

Modified: trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java?view=diff&rev=16146&p1=trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java&p2=trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java&r1=16145&r2=16146
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/uml/generator/TempFileUtils.java	2008-11-23 09:47:50-0800
@@ -105,6 +105,9 @@
                     // cpp generator, which always creates backup files (it's a

                     // bug).

                     if (!f.isDirectory() && !f.getName().endsWith(".bak")) {

+                        // TODO: This is using the default platform character

+                        // encoding.  Specifying an encoding will produce more 

+                        // predictable results

                         FileReader fr = new FileReader(f);

                         BufferedReader bfr = new BufferedReader(fr);

                         try {