svn commit: r16321 - trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java

Author: tfmorris
Date: 2008-12-10 14:16:17-0800
New Revision: 16321

Modified:
   trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java

Log:
Restore poor design TODO and expand it to make it easier to understand for future readers

Modified: trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java?view=diff&pathrev=16321&r1=16320&r2=16321
==============================================================================
--- trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java	(original)
+++ trunk/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeModelElement.java	2008-12-10 14:16:17-0800
@@ -141,6 +141,14 @@
 
 
     private NotationProvider notationProviderName;
+    
+    // TODO: This is a very memory inefficient design because:
+    // a) HashMaps are MUCH larger then necessary for this object
+    //    ~224 bytes vs. 24 bytes for 4 parameters - see
+    //    https://www.sdn.sap.com/irj/scn/weblogs?blog=/pub/wlg/5163
+    // b) the notation settings objects aren't shared even though most of
+    // them will be identical
+    // It's also performance inefficient, although that's less of a concern
     // TODO: The opaqueness of the string keys prevents us finding uses
     private HashMap<String, Object> npArguments;
     /**

------------------------------------------------------
http://argouml.tigris.org/ds/viewMessage.do?dsForumId=5905&dsMessageId=982572

To unsubscribe from this discussion, e-mail: [[email protected]].