svn commit: r16955 - trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java

Author: tfmorris
Date: 2009-03-26 11:12:26-0700
New Revision: 16955

Modified:
   trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java

Log:
TODOs

Modified: trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java
Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java?view=diff&pathrev=16955&r1=16954&r2=16955
==============================================================================
--- trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java	(original)
+++ trunk/src/argouml-core-model-mdr/src/org/argouml/model/mdr/FacadeMDRImpl.java	2009-03-26 11:12:26-0700
@@ -2669,9 +2669,12 @@
 
     public List<Feature> getOperationsAndReceptions(Object classifier) {
         List<Feature> opsAndReceps = new ArrayList<Feature>();
-        for (Feature f : getFeatures(classifier)) {
-            if (isAOperation(f) || isAReception(f)) {
-                opsAndReceps.add(f);
+        // TODO: Return empty collection on null input or throw IllegalArgument?
+        if (classifier != null) {
+            for (Feature f : getFeatures(classifier)) {
+                if (isAOperation(f) || isAReception(f)) {
+                    opsAndReceps.add(f);
+                }
             }
         }
         return opsAndReceps;
@@ -2851,6 +2854,7 @@
     public Collection<Message> getPredecessors(Object handle) {
         try {
             if (handle instanceof Message) {
+            // TODO: This has different semantics than everything else
                 return Collections.unmodifiableCollection(
                         new ArrayList<Message>(
                                 ((Message) handle).getPredecessor()));

------------------------------------------------------
http://argouml.tigris.org/ds/viewMessage.do?dsForumId=5905&dsMessageId=1433234

To unsubscribe from this discussion, e-mail: [[email protected]].