[phpldapadmin] [ phpldapadmin-Patches-2240107 ] gettext, pcre and session detection

Patches item #2240107, was opened at 2008-11-08 18:54
Message generated for change (Comment added) made by wurley
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=2240107&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Ilia Chipitsine (chipitsine)
Assigned to: Nobody/Anonymous (nobody)
Summary: gettext, pcre and session detection

Initial Comment:
here's second version of a previously submitted patch, now it detects

gettext
pcre
php-session

----------------------------------------------------------------------

Comment By: Deon George (wurley)
Date: 2008-12-12 13:53

Message:
OK, I've applied a fix for this - a little different to what you provided,
but hopefully the same result.

----------------------------------------------------------------------

Comment By: Ilia Chipitsine (chipitsine)
Date: 2008-12-08 07:15

Message:
I've double checked, my patch was only partially applied. Probably, it's my
fault as well, because I sent it twice, first for gettext, and later
combined patch for gettext + pcre + session

so ... I checked out BRANCH_1_1 ... and first thing I seen, that pcre is
called before it is being detected, look:

Fatal error: Call to undefined function preg_replace() in
/usr/local/www/apache22/data/phpldapadmin/lib/functions.php on line 174

second thing I've seen was detecting gettext and calling error() which
itself calls gettext.


I attach a patch against BRANCH_1_1, please, apply it 
File Added: pla-branch_1_1.diff

----------------------------------------------------------------------

Comment By: Deon George (wurley)
Date: 2008-12-07 16:05

Message:
Im thinking you are using the wrong BRANCH - you patch is already applied
in CVS.

Patches for 1.1.x release are in BRANCH-1_1_0
http://phpldapadmin.cvs.sourceforge.net/viewvc/phpldapadmin/phpldapadmin/htdocs/index.php?view=log&pathrev=BRANCH-1_1_0

Also, error has also been patch to test for gettext before calling _().
http://phpldapadmin.cvs.sourceforge.net/viewvc/phpldapadmin/phpldapadmin/lib/functions.php?view=diff&pathrev=BRANCH-1_1_0&r1=1.303.2.26&r2=1.303.2.27

----------------------------------------------------------------------

Comment By: Ilia Chipitsine (chipitsine)
Date: 2008-12-06 19:29

Message:
I checked out CVS version of PLA today and it still doesn't contain my
patch

htdocs/index.php:

if (! extension_loaded('gettext'))
        error('<p>Your install of PHP appears to be missing GETTEXT
support.</p><p>GETTEXT is used for language translation.</p><p>Please
install GETTEXT support
 before using phpLDAPadmin.<br /><small>(Dont forget to restart your web
server afterwards)</small></p>','error',true);
...........


so, if php is compiled without gettext, "error" function is called. but
"error" itself calls _(), which is gettext function.


File Added: pla2.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=2240107&group_id=61828

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/