[phpldapadmin] [ phpldapadmin-Patches-2726512 ] Cleanup and generalize auto_number search support

Patches item #2726512, was opened at 2009-04-02 12:08
Message generated for change (Tracker Item Submitted) made by bigfoot_hunter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=2726512&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthijs Kooijman (bigfoot_hunter)
Assigned to: Nobody/Anonymous (nobody)
Summary: Cleanup and generalize auto_number search support

Initial Comment:
The attached patch concerns the auto_number feature, and in particular the search mechanism.

Previously, the search mechanism could only be used for the uid and gid "types", which map to the uidNumber and gidNumber attributes. This patch changes that, so now an arbitrary attribute can be used a type. For backwards compatibility, the special "uid" and "gid' types are still supported.

The changes made mean that instead of doing a search with a hardcoded filter of (|(uidNumber=*)(gidNumber=*)), it now only searches for items with the attribute we're looking for. Also, the actual code was horribly redundant. By rewriting algorithm to not use an intermediate hash, we use only two loops and a single datastructure, instead of four loops and three datastructures. This should reduce both memory and cpu load.

Lastly, the function documentation was largely out of date, still referring to uidNumbers only. It has been updated to reflect the actual code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=2726512&group_id=61828

------------------------------------------------------------------------------
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/