[phpldapadmin] [ phpldapadmin-Bugs-2797836 ] REGEX error in clean_search_vals

Bugs item #2797836, was opened at 2009-05-28 20:58
Message generated for change (Settings changed) made by wurley
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2797836&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: christian deligant (deligant)
Assigned to: Nobody/Anonymous (nobody)
Summary: REGEX error in clean_search_vals

Initial Comment:
If you provide the function  with something like "Medico (di famiglia)", the function fails to escape and returns as if it was already a filter expression

The reason is a missing "^" in the second regex...
ORIGINAL (lines 2852-2853):
	# The string- might be a proper search filter
	if (preg_match('/^\([&\|!]\(/',$val) || (preg_match('/\(([^\(|\)])*\)/',$val))) {

SHOULD BE
	# The string might be a proper search filter
	if (preg_match('/^\([&\|!]\(/',$val) || (preg_match('/^\(([^\(|\)])*\)/',$val))) {

This is the header of the file (version released in the debian Lenny package)
// $Header: /cvsroot/phpldapadmin/phpldapadmin/lib/functions.php,v 1.303.2.26 2008/01/30 11:17:00 wurley Exp $


----------------------------------------------------------------------

>Comment By: Deon George (wurley)
Date: 2009-06-18 23:25

Message:
I'm not applying this. The next release of PLA is not using
clean_search_vals() - instead you need to escape the parenthesis if it is
part of the value (as you would on the command line with ldapsearch).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2797836&group_id=61828

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/