[phpldapadmin] [ phpldapadmin-Bugs-2809461 ] Declaration of AJAXTree::draw_dn() should be compatible with

Bugs item #2809461, was opened at 2009-06-20 22:55
Message generated for change (Comment added) made by wurley
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2809461&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: pmenier (pmenier)
Assigned to: Nobody/Anonymous (nobody)
>Summary: Declaration of AJAXTree::draw_dn() should be compatible with

Initial Comment:
While attempting to log in my ldapadmin, i get this error since i upgrade php to 5.2.10. All was working fine with php-5.2.9. 

All comments in attachments.

----------------------------------------------------------------------

>Comment By: Deon George (wurley)
Date: 2009-06-28 15:32

Message:
Change commited to CVS to fix this - PLA seems to work OK now on PHP
5.2.10.

(Change $level=0 to $level on draw_dn() function declaration).

lib/AJAXTree.php 1.2.2.2

----------------------------------------------------------------------

Comment By: pmenier (pmenier)
Date: 2009-06-21 17:22

Message:
1) Trying WIP-20090620 without any change gives:

Fatal error: Class 'AJAXTree' not found in
/web/clients/mairie/www/phpldapadmin/lib/Tree.php(50) : eval()'d code on
line 1

2) After making changes (draw_dn() fix ) i get a HTTP 500. Apache's log
shows me:

[Sun Jun 21 09:03:57 2009] [error] [client 83.115.144.242] Premature end
of script headers: cmd.php, referer:
http://xxxxxxxxxx/phpldapadmin/htdocs/index.php?server_id=1&redirect=true

3) Now back to the original files (on version 1.1.0.7) and changing
$level=0 by $level in function draw_dn => works fine !


----------------------------------------------------------------------

Comment By: Deon George (wurley)
Date: 2009-06-21 10:22

Message:
OK, can I ask two more things:
* Back to the original files, do you still get the error if you change
$level=0 to $level in AJAXTree.php? (So it has the same two first arguments
as PLMTree).

(I think this error is wrong in 5.2.10, but anyway....)

Also, since you are trying the latest and greatest PHP, would you like to
also test the latest and greatest PLA? WIP-20090620 should be fairly stable
now. (You'll need to make the same draw_dn() fix - I'll commit a fix to CVS
when I hear back from you about this last idea. (my preference is for this
last fix...))

----------------------------------------------------------------------

Comment By: pmenier (pmenier)
Date: 2009-06-21 02:20

Message:
----------------------------------------------------------------------

> >Comment By: Deon George (wurley)
Date: 2009-06-21 00:21

Message:
Tell me which one of these fixes the problem (try them in this order):

* changing function draw_dn() from protected to private in AJAXTree.php,

Result:
Fatal error: Access level to AJAXTree::draw_dn() must be protected (as in
class PLMTree) or weaker

or
* changing function draw_dn() from protected to private in AJAXTree.php,
PLMTree.php and HTMLTree.php, 

Result: Erreur
E_STRICT: Declaration of AJAXTree::draw_dn() should be compatible with
that of PLMTree::draw_dn()

or
* changing the function definition in lib/HTMLTree and lib/PLMTree.php to
use the same definition as AJAXTree.php.

Result: works fine !!! It just take more time to display pages.


...deon


----------------------------------------------------------------------

Comment By: Deon George (wurley)
Date: 2009-06-21 00:21

Message:
Tell me which one of these fixes the problem (try them in this order):

* changing function draw_dn() from protected to private in AJAXTree.php,
or
* changing function draw_dn() from protected to private in AJAXTree.php,
PLMTree.php and HTMLTree.php, or
* changing the function definition in lib/HTMLTree and lib/PLMTree.php to
use the same definition as AJAXTree.php.

...deon

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2809461&group_id=61828

------------------------------------------------------------------------------
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/