[phpldapadmin] [ phpldapadmin-Bugs-2839213 ] Few localization -related bugs

Bugs item #2839213, was opened at 2009-08-17 23:28
Message generated for change (Comment added) made by twrharri
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2839213&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: 1.2.x
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: twrharri (twrharri)
Assigned to: Nobody/Anonymous (nobody)
Summary: Few localization -related bugs

Initial Comment:
Hi,

I found few bugs as I finalized finnish localizatioon of PLA. I Might also submit a patch, but these might be things to fix. 


1. QueryRender.php: printf('<option value="%s" %s>%s</option>','none','',_('Custom Query')); // Missing _ front of ('Custon Query') 

2. TemplateRender.php: 
$subtitle .= sprintf('%s: <b>%s</b>',_('Template'),$this->template->getID() != 'none' ? $this->template->getTitle() : _('Default')); // Missing _ front of ('Template')? Not found from localization message.po

and later same thing:

$subtitle .= sprintf('%s: <b>%s</b>',_('Template'),$this->template->getID() != 'none' ? $this->template->getTitle() : _('Default')); // Missing _ front of ('Template')? Not found from localization message.po

3- QueryRender.php:
___ clip ___
 foreach (array('list','table') as $f) {
 echo '&nbsp;';
if (get_request('format','REQUEST') == $f) {
printf('<b>%s</b>',_($f));
___ clip __

Result format changer does not seem to be localized at all on result page. On query page localization of formats is ok.

Thanks for all.

Regs, 
Harri

----------------------------------------------------------------------

>Comment By: twrharri (twrharri)
Date: 2009-08-18 09:17

Message:
Hello,

Now it seems to be ok. Thanks.

Regs,
Harri

----------------------------------------------------------------------

Comment By: Deon George (wurley)
Date: 2009-08-18 01:12

Message:
Thanks for the fixes.

I've applied 1&2 as you have detailed.

For 3), tell me if it is resolved when you change:
$_SESSION[APPCONFIG]->getValue('search','display') == 'list' ? 'selected'
: '',_('List'));
to
$_SESSION[APPCONFIG]->getValue('search','display') == 'list' ? 'selected'
: '',_('list'));

in lib/QueryRender (around line 104) (and the same for _('Table') to
('table') on the lines below.

Also edit your .mo file and change "List" to "list" and "Table" to "table"
for those msgid's.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498546&aid=2839213&group_id=61828

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/