Re: Conf files
Jean-Christophe Michel <jc.michel-/aRvmaKoZxNWk0Htik3J/[email protected]> Wed, 25 May 2005 15:17:25 +0200
| Newsgroups | gmane.comp.lib.binarycloud.devel |
|---|---|
| Message-ID | <[email protected]> |
B. Kamer wrote: > What defines a FACTORY and WORKSPACE value? > > I thought all files from binarycloud/* & vortex/* should be loaded > automaticly into the FACTORY realm. This way vortex modules will work > with default (FACTORY) settings. Then when the user needs modified > configuration then he must copy it to WORKSPACE/conf and modify that file. > > If this i true why would it be a feature NOT to load vortex FACTORY > settings? What's the use of this feature? Disabled until conf comes > from a database? Exactly. If you want to implement it, why not. Thought I can think to some cases when it would be dangerous to run with factory settings for vortex conf: upload dir path, authorized download file types, etc. >> I don't agree for vortex/, see above. You need to have a way to modify a >> factory conf. > > The user would never have to modify FACTORY setting? He should copy the > file to WORKSPACE/conf and modify tha one. The Conf::get() will get the > highest available level. That was the meaning of my sentence :-) >> Since the file name tells it's a conf file, why add a dir? > > consistency between the three places > > either binarcyloud/*.conf.xml should move to binarcyloud/conf/ > *.conf.xml or vortex/conf/*.conf.xml to vortex/*.conf.xml I see no conf file in binarycloud/*.conf.xml :/ >> I agree if your changes allow to implement FACTORY/WORKSPACE conf level >> as defined in Conf.php. I think these changes were intended for a sql >> based conf, and xml was consciously limited to read values in workspace. > > If all file in the packages binarycloud/vortex/apps are consider > FACTORY settings (whether automatically read or not) and manually > placed conf files placed in WORKSPACE/conf nothing would change here... Ah... sorry, I really thought xml conf was not correctl handled regarding factory/workspace settings. Good news if it works! > sorry to be a bit neurotic on this, i just think looking at the code > should make it clear how thinks work (especially since the docs are > old). Exceptions are fine, but the fewer the better. Ok, proceed if you want; I'd prefer not to have a conf dir for factory (binarycloud/ and vortex/) if possible though. -- Jean-Christophe Michel _______________________________________________ dev mailing list dev-PnctHDZWAvB/Cz2I37pSEPZ4XP/[email protected] http://lists.binarycloud.com/mailman/listinfo/dev