[Boost] [Review] [Boost.MySQL] - Review Complete

--===============6333428429143816522==
Content-Type: multipart/alternative; boundary="0000000000005eda0505e180e28a"

--0000000000005eda0505e180e28a
Content-Type: text/plain; charset="UTF-8"

Dear All,

The submission of Boost.MySQL has created plenty of "lively debate".

Unsurprisingly, a library which is based on Asio, of which there are few
experts, has given rise to a great deal of questioning around performance,
memory re-use, correct return types and so on.

It has been noted that Reuben, the library's author, has been very
responsive. Both in this mailing list and in terms of raising PRs.

A specific concern was raised about the name of the library, and whether it
infringed any commercial trade marks. Reuben took the trouble to reach out
to Oracle to check. They have responded that there is no infringement and
we may use the name.

In the end though, despite a great deal of words written raising concerns,
ideas and suggestions, we received size reviews, all of which were high
quality.

The results were:
Accept: 3
Conditional Accept: 2
Reject: 1

Having carefully weighed up:
- The stated aims of the library
- The quality of the implementation
- The demonstrated responsiveness of the author
- The value of the library to users of MySQL
- The value of the library as a teaching tool for implementing a complex,
cancellable, asynchronous protocol on ASIO, which correctly adapts to the
use of user-selection completion tokens,

It seems right to ACCEPT this library into Boost.

My congratulations to Reuben.


-- 
Richard Hodges
[email protected]
office: +44 2032 898 513
home: +376 861 195
mobile: +376 380 212

--0000000000005eda0505e180e28a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Dear All,<div><br></div><div>The submission of Boost.MySQL=
 has created plenty of &quot;lively debate&quot;.</div><div><br></div><div>=
Unsurprisingly, a library which is based on Asio, of which there are few ex=
perts, has given rise to a great deal of questioning around performance, me=
mory re-use, correct return types and so on.</div><div><br></div><div>It ha=
s been noted that Reuben, the library&#39;s author, has been very responsiv=
e. Both in this mailing list and in terms of raising PRs.</div><div><br></d=
iv><div>A specific concern was raised about the name of the library, and wh=
ether it infringed any commercial trade marks. Reuben took the trouble to r=
each out to Oracle to check. They have responded that there is no infringem=
ent=C2=A0and we may use the name.</div><div><br></div><div>In the end thoug=
h, despite=C2=A0a great deal of words written raising concerns, ideas and s=
uggestions, we received size reviews, all of which were high quality.</div>=
<div><br></div><div>The results were:</div><div>Accept: 3</div><div>Conditi=
onal Accept: 2</div><div>Reject: 1</div><div><br></div><div>Having carefull=
y weighed up:</div><div>- The stated aims of the library</div><div>- The qu=
ality of the implementation</div><div>- The demonstrated responsiveness of =
the author</div><div>- The value of the library to users of MySQL</div><div=
>- The value of the library as a teaching tool for implementing a complex, =
cancellable, asynchronous=C2=A0protocol on ASIO, which correctly adapts to =
the use of user-selection completion tokens,</div><div><br></div><div>It se=
ems right to ACCEPT this library into Boost.</div><div><br></div><div>My co=
ngratulations to Reuben.</div><div><br></div><div><div><br></div>-- <br><di=
v dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature">=
<div dir=3D"ltr"><div><div dir=3D"ltr">Richard Hodges<div><a href=3D"mailto=
:[email protected]" target=3D"_blank">[email protected]</a></div><div>off=
ice: +44 2032 898 513</div><div>home: +376 861 195</div><div>mobile:=C2=A0+=
376 380 212</div><div><br></div></div></div></div></div></div></div>

--0000000000005eda0505e180e28a--

--===============6333428429143816522==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline