Re: [multi] Formal Review Begins
Matt Borland via Boost <[email protected]>
| Newsgroups | gmane.comp.lib.boost.devel |
|---|---|
| Message-ID | <Duf627gWWqQCCCoh_lEFkkYil6maRsvxWse2aveNRkYdsZNsDERVkamccj-vRxVem4G40guzoQlFd0IW9j-_YcH43jvlk4s9lmrTrrR_Wgg=@mattborland.com> |
> > Therefor, I recommend to CONDITIONAL ACCEPT the library with the following > conditions: > > 1. Rename the types so they are intuitive to C++ developers, for example as > described above. > 2. Remove or generalize (make available to all N) functions currently only > available for N =1 (e.g. data()) > 3. Make array_ref and subarray the same type. > 4. Provide algorithms as free functions. > 5. Remove the `extensions()` function if it is the same as a C for-loop. > 6. Remove `dynamic_array` or give it a better name like `unique_array`. > Thank you for your review and comments Klemens. Your acceptance conditions are noted. Matt _______________________________________________ Boost mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/[email protected]/message/VMXE23M3N6SRK3B2ZR2SNTFAU3IKQCRF/
publickey - [email protected] - 0xC1382EAD.asc
(application/pgp-keys, 653 B)
-----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX2wgdBYJKwYBBAHaRw8BAQdAUHOh0KpbZCszhdvKztWj4C6FR1ozMBQE waBi3m2PJHLNK21hdHRAbWF0dGJvcmxhbmQuY29tIDxtYXR0QG1hdHRib3Js YW5kLmNvbT7CjwQQFgoAIAUCX2wgdAYLCQcIAwIEFQgKAgQWAgEAAhkBAhsD Ah4BACEJEFmBWlVCFaWlFiEEwTgurTcoHwbdSbIsWYFaVUIVpaVWuwEA77rm OA4TB6Xxe6q8gI42bEICMhMyZKSMcakz39/djYkBAMJOG+IGQC/d0n3dsl10 Kg/oxX88kFO1oPKn4/XW+ToBzjgEX2wgdBIKKwYBBAGXVQEFAQEHQOsmo6wR UuXRAvFIiqmQkzYrPyvKYKna2z4ZtmnTQMkMAwEIB8J4BBgWCAAJBQJfbCB0 AhsMACEJEFmBWlVCFaWlFiEEwTgurTcoHwbdSbIsWYFaVUIVpaWUJwEA5G0c ZRnG5WGNErI+y90iQrTv02i4Ivhv7twoFcLD/zwA/jKypw+vehE99mEj1/uI EkoDFlNzQZqNldbjRcPyI5UH =462S -----END PGP PUBLIC KEY BLOCK-----
signature.asc
(application/pgp-signature, 343 B)
-----BEGIN PGP SIGNATURE----- Version: ProtonMail wrsEARYKAG0FgmmtjAAJEFmBWlVCFaWlRRQAAAAAABwAIHNhbHRAbm90YXRp b25zLm9wZW5wZ3Bqcy5vcmdxX1Pw+5BkCyA/v8hcaLU3G6N2UGBBb2Ty/MpM AW75BRYhBME4Lq03KB8G3UmyLFmBWlVCFaWlAABgRQD/YDEEoxb/ad95ytKK DWg/Ynsugcxf8cTjCy7ucGe/8okBAJYNst3Qxy5e6KMNR81eU1SpFOsqIT6y kg8kwPd2I7II =BQ7B -----END PGP SIGNATURE-----