Re: [review] [hub] boost::container::hub review starts on April 16
Andrzej Krzemienski via Boost <[email protected]>
| Newsgroups | gmane.comp.lib.boost.devel |
|---|---|
| Message-ID | <CAOenAXi_Vj5WRtXWGnitrJXy=vQ=SZLYi1dqvTzi3Hsk0i8T0A@mail.gmail.com> |
sob., 11 kwi 2026 o 10:01 Joaquín M López Muñoz <[email protected]> napisał(a): > > > > No dia 10 de abr. de 2026, às 21:22, Andrzej Krzemienski via Boost < > [email protected]> escreveu: > > > > Hi All, > > Thank you Joaquín for writing and sharing the library, and sorry if this > > sounds ungrateful, but looking at the documentation, it doesn't look > > comfortable. > > It looks like it assumes one is already familiar with std::hive, but it > is > > difficult for a regular C++ programmer to learn hive. Even the common > > source of truth -- cppreference.com -- doesn't have std::hive > documented. > > > > Are the users expected to use https://eel.is/c++draft/sequences#hive as > > reference, and p0447r28 as motivation? > > I would expect a library to be self-contained: the documentation comes > with > > the sources. > > Hi Andrezj. Nothing ungrateful about your observations :-) This submission > is a little bit of uncharted territory to me as the proposal is for a > Boost.Container component rather than a library of its own (though this is > going to be discussed during the review, I think), and this has led me to > be somewhat hesitant about how extensive the documentation should be (which > is currently just the README.md file in wait for eventual integration into > Boost.Container docs). > > But your feedback is clear and I will extend the docs to be as > self-contained as possible. I’ll do that before the review begins. Ok, I understand the situation. In that case I would reduce my expectations. I would expect to find the following minimum information that would help users understand the motivation and determine if they want to use it: container::hub is a good choice when you perform frequent insertions and deletions, and the access to elements is via iterating over all elements in the sequence. Upon every erasure a hole is left, which is then skipped during the iterations. Subsequent insertions fill these holes. Its iterators are bidirectional iterators. Insertion and erasure require O(1) operations on T, and do not invalidate iterators to non-erased elements. Regards, &rzej; _______________________________________________ Boost mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/[email protected]/message/NPBX7HCWMKAY3AHBLDQQUW5AOIISST7Y/