Re: [review] Reminder: The review of boost::container::hub ends April 26
Andrzej Krzemienski via Boost <[email protected]>
| Newsgroups | gmane.comp.lib.boost.devel |
|---|---|
| Message-ID | <CAOenAXgn7Q9Wad=e8n8PSErgJtEUyDxYJiordKVNOsGWzZEk5g@mail.gmail.com> |
pon., 27 kwi 2026 o 16:08 Peter Dimov via Boost <[email protected]> napisał(a): > Joaquin M López Muñoz wrote: > > > - get_iterator should assert if the user passes an invalid pointer. > > > I'd assert on the mask bit being set. > > Yes. I'm a little mystified by the standard spec for this as > get_iterator is marked > > noexcept, so it's violating Lakos Rule if I'm not wrong. DR worthy? > > Probably. > > It's not clear how Lakos interacts with hardened preconditions, but it's > worth an open issue either way. > A hardened precondition is one that runtime-checks and aborts in a hardened implementation, and that behaves like any other precondition in non-hardened implementation. Switching between a hardened and a non-hardened implementation can be done via a compiler command flag. Because of this non-hardened variant, the Lakos rule still applies. Regards, &rzej; > > > _______________________________________________ > Boost mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ > Archived at: > https://lists.boost.org/archives/list/[email protected]/message/DQXIOU5C3VUBFT7NPICBPVWOU4MYIIHH/ > _______________________________________________ Boost mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/[email protected]/message/BI36QXK5IQADUURWUGQKMG67BTK6FJCG/