[hub] Post-review version ready
Joaquin M López Muñoz via Boost <[email protected]>
| Newsgroups | gmane.comp.lib.boost.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, I've finished integrating the feedback given at the review of boost::container::hub: * Branch: https://github.com/joaquintides/hub/tree/feature/review-feedback * PR: https://github.com/joaquintides/hub/pull/20 * Changes: * Fix typos (Matt Borland) * Fix test_api for GCC on darwin (Matt Borland) * Fix iterator de-reference (Matt Borland) * enabled warnings in CI (Matt Borland) * removed undocumented memory() (Andrzej Krzemieński) * typos (Arnaud Becheler) * worked around bogus array bounds warning in GCC (Andrzej Krzemieński/Peter Dimov) * integrated AppVeyor CI (Alexander Grund) * hardened get_iterator (Emil Dotchevski) * Fix B2 + CMake testing (Matt Borland) * replaced visit[_all][_while] with global for_each[_while] (Andrzej Krzemieński) * used aligned new when available and required (Emil Dotchevski) * added exception safety tests and made single-element insertion strongly safe (Emil Dotchevski) * clarified exception guarantees and preconditions of sort (Emil Dotchevski) * s/HFT/high-frequency trading (Peter Turcan) * improved somewhat introductory statement to hub (Peter Turcan, Arnaud Becheler) * made it clear that hub is not a sequence container (Andrzej Krzemieński) * reserved right to change block capacity (64 elements) in the future (Emil Dotchevski) * explained by block size is 64 (Peter Turcan) * improve code comments in tutorial, expanded section on capacity (Peter Turcan, Arnaud Becheler) Review feedback _not_ included in this version: * Implement a slot map (Chris Mazakas): this is more for the evolution track * Contiguous hub with VirtualAlloc (Chris Mazakas): same * Improve perf table presentation (Matt Borland/Dominique Devienne): I'll see to that when the docs are integrated into Boost.Container's I'd be grateful if you could take a look, comment and maybe warn about feedback I may have overlooked. When Ion gives me the OK, I'll merge and begin working with him on integration into Boost.Container, hopefully in time for Boost 1.92. Thank you, Joaquín M López Muñoz _______________________________________________ Boost mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/[email protected]/message/5CZTSS3C2U3BFKJSR3QE6AUMZZMCFTYR/