Re: Capy and Corosio review

Ruben Perez via Boost <[email protected]> Tue, 30 Jun 2026 12:59:34 +0200
Newsgroups gmane.comp.lib.boost.devel
Message-ID <CACR-mdL3T7voKqdCANew2Z-bNo5fuFLbXsb+StMC0PQRSmkWGA@mail.gmail.com>
> - Finally, POSIX signal handling is not async-signal-safe
> (corosio/include/boost/corosio/native/detail/posix/posix_signal_service.hpp).
> This is documented, but it's a regression against Asio, which performs
> only an async-signal-safe `write()` to a self-pipe (or uses `signalfd`)
> in the handler and does the real work on a normal thread.

I've been reviewing posix_signal_service implementation and it locks
mutexes and calls a virtual function that locks more mutexes and
allocates memory. This implementation is dangerous. I'm adding
properly addressing this as an acceptance condition to my review.
_______________________________________________
Boost mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/[email protected]/message/E2APZ5GQAHX2HO2ANQBE7Q5YOTCDWUZW/